Skip to content

Shorten Dispatcher logging comments, docstrings and test names - #25504

Merged
AAraKKe merged 1 commit into
masterfrom
aarakke/dispatcher-logging-cleanup
Oct 5, 2026
Merged

AAraKKe merged 1 commit into
masterfrom
aarakke/dispatcher-logging-cleanup

Conversation

@AAraKKe

@AAraKKe AAraKKe commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Stack (merge in order):

  1. Shorten Dispatcher logging comments, docstrings and test names #25504 Shorten Dispatcher logging comments, docstrings and test names ← this PR
  2. Report cancelled and timed-out Dispatcher batches and jobs #25505 Report cancelled Dispatcher batches and jobs as cancelled, not failed

What does this PR do?

Shortens the comments, docstrings and test names added in #25491, which merged before this review pass. No behaviour changes.

Motivation

Several docstrings narrated what the code already shows, and some test names read as full sentences of clauses. This keeps the comments to the reasons and the names to the behaviour under test.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label Oct 5, 2026
@dd-octo-sts dd-octo-sts Bot added the ddev label Oct 5, 2026
@AAraKKe
AAraKKe force-pushed the aarakke/dispatcher-logging-cleanup branch from 336803d to f1da5e5 Compare October 5, 2026 12:55
@dd-octo-sts

dd-octo-sts Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dispatcher tests: passed

Dispatcher beta: informational only
Existing CI remains the merge signal.

  2/2 jobs

✅ 2 passed · nothing failed

Batches · ✅ batch-01 2/2

Dispatcher finished on e9fd456 — GitHub Run · Dispatcher Logs.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: RUN-ALL — every test task will run
Trigger:         empty diff (default branch, scheduled run, or shallow-clone fallback)
Test tasks:      0 (all selected)
Publish tasks:   2 (always emitted)
Diff:            empty (no diff information)

Learn more about CI impact filtering

@datadog-official

datadog-official Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 89.50% (+0.09%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f1da5e5 | Docs | View more details | Give us feedback!

@AAraKKe
AAraKKe marked this pull request as ready for review October 5, 2026 13:17
@AAraKKe
AAraKKe requested a review from a team as a code owner October 5, 2026 13:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T13:22:54.906160Z f1da5e5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dd-octo-sts

dd-octo-sts Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file ✅
ci Validate CI configuration and code coverage settings ✅
codeowners Validate every integration has a CODEOWNERS entry ✅
config Validate default configuration files against spec.yaml ✅
dep Verify dependency pins are consistent and Agent-compatible ✅
http Validate integrations use the HTTP wrapper correctly ✅
imports Validate check imports do not use deprecated modules ✅
integration-style Validate check code style conventions ✅
jmx-metrics Validate JMX metrics definition files and config ✅
labeler Validate PR labeler config matches integration directories ✅
legacy-signature Validate no integration uses the legacy Agent check signature ✅
license-headers Validate Python files have proper license headers ✅
licenses Validate third-party license attribution list ✅
metadata Validate metadata.csv metric definitions ✅
models Validate configuration data models match spec.yaml ✅
openmetrics Validate OpenMetrics integrations disable the metric limit ✅
package Validate Python package metadata and naming ✅
qa-label Validate the pull request declares whether it needs QA for the next Agent release ✅
readmes Validate README files have required sections ✅
saved-views Validate saved view JSON file structure and fields ✅
version Validate version consistency between package and changelog ✅

View full run

@AAraKKe
AAraKKe enabled auto-merge October 5, 2026 13:35
@AAraKKe
AAraKKe added this pull request to the merge queue Oct 5, 2026
Merged via the queue into master with commit 5d6448b Oct 5, 2026
396 of 397 checks passed
@AAraKKe
AAraKKe deleted the aarakke/dispatcher-logging-cleanup branch October 5, 2026 13:38
@dd-octo-sts dd-octo-sts Bot added this to the 7.86.0 milestone Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants