Skip to content

ci: have sccache ignore s3 backend errors - #20620

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
brettlangdon/sccache-ignore-error
Sep 29, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
brettlangdon/sccache-ignore-error

Conversation

@brettlangdon

@brettlangdon brettlangdon commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

No description provided.

@brettlangdon
brettlangdon requested review from a team as code owners September 29, 2026 13:41
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 29, 2026
@brettlangdon
brettlangdon requested review from Yun-Kim and emmettbutler and removed request for a team September 29, 2026 13:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T13:43:23.110555Z d93a24f PR opened
🔒 Security Review ✅ Completed 2026-09-29T13:44:22.044071Z d93a24f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@KowalskiThomas KowalskiThomas added the ci-reliability The PR is related to the CI reliability of dd-trace-py label Sep 29, 2026
@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codeowners resolved as

Resolved from the full PR diff against main using the target branch CODEOWNERS file.
CODEOWNERS team requests not listed below are not required by the current file set.

No remaining files require a CODEOWNERS review.

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

⚠️ Existing circular imports

There are 1 circular imports that already exist on the base branch and have not been changed by this PR.

ddtrace.errortracking._handled_exceptions.bytecode_injector -> ddtrace.errortracking._handled_exceptions.callbacks -> ddtrace.errortracking._handled_exceptions.collector -> ddtrace.errortracking._handled_exceptions.bytecode_reporting -> ddtrace.errortracking._handled_exceptions.bytecode_injector

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Dependency direction analysis

⚠️ Existing dependency direction violations

There are 201 dependency direction violations that already exist on the base branch and have not been changed by this PR.

Show existing violations (showing 5 of 201 highest severity)
ddtrace.internal.tracemethods -×-> ddtrace.trace  (internal-core -> product:tracing, score=132)
ddtrace.llmobs._integrations.llama_index -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=130)
ddtrace.llmobs._integrations.google_adk -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=130)
ddtrace.internal.test_visibility.api -×-> ddtrace.trace  (product:ci_visibility -> product:tracing, score=130)
ddtrace.llmobs._integrations.anthropic -×-> ddtrace.trace  (product:llmobs -> product:tracing, score=130)

To see all violations, download the layers-base.json and layers-pr.json artifacts from this CI job and run:

uv run --script scripts/import-analysis/layers.py compare layers-base.json layers-pr.json

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🚧 18 tests that failed were ignored due to quarantine View in Datadog

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d93a24f | Docs | View more details | Give us feedback!

@pr-commenter

pr-commenter Bot commented Sep 29, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-09-29 14:18:45

Comparing candidate commit d93a24f in PR branch brettlangdon/sccache-ignore-error with baseline commit 521cee0 in branch main.

📊 Benchmarking dashboard

Found 0 performance improvements and 10 performance regressions! Performance is the same for 591 metrics, 10 unstable metrics, 7 known flaky benchmarks, 17 flaky benchmarks without significant changes.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:httppropagationextract-empty_headers

  • 🟥 execution_time [+92.233ns; +110.326ns] or [+12.666%; +15.151%]

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+9.548µs; +10.866µs] or [+11.321%; +12.883%]

scenario:iastaspects-format_map_noaspect

  • 🟥 execution_time [+107.060µs; +114.786µs] or [+30.982%; +33.218%]

scenario:iastaspects-title_aspect

  • 🟥 execution_time [+98.880µs; +104.064µs] or [+36.465%; +38.377%]

scenario:iastaspectsremodule-re_expand_aspect

  • 🟥 execution_time [+84.115µs; +94.769µs] or [+13.301%; +14.986%]

scenario:msgpackencoderscenario-simple_one_span

  • 🟥 execution_time [+494.986ns; +549.806ns] or [+11.931%; +13.252%]

scenario:openfeatureflagevaluation-hook-enqueue-typical

  • 🟥 execution_time [+1.624µs; +1.757µs] or [+7.700%; +8.326%]

scenario:otelspan-start

  • 🟥 execution_time [+1.984ms; +2.852ms] or [+8.087%; +11.622%]

scenario:recursivecomputation-shallow

  • 🟥 execution_time [+49.274µs; +52.966µs] or [+7.016%; +7.542%]

scenario:span-start-finish-telemetry

  • 🟥 execution_time [+4.298ms; +4.493ms] or [+10.498%; +10.973%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:coreapiscenario-context_with_data_listeners

  • unstable execution_time [-730.481ns; +750.764ns] or [-7.026%; +7.221%]

scenario:coreapiscenario-core_dispatch_1_listener

  • unstable execution_time [-36.898ns; +41.552ns] or [-5.558%; +6.259%]

scenario:coreapiscenario-core_dispatch_50_listeners

  • unstable execution_time [-1940.692ns; +1887.888ns] or [-9.773%; +9.507%]

scenario:coreapiscenario-core_dispatch_exception_listeners

  • unstable execution_time [-2090.156ns; +1606.239ns] or [-10.832%; +8.324%]

scenario:coreapiscenario-core_dispatch_listeners

  • unstable execution_time [-390.685ns; +372.562ns] or [-9.195%; +8.769%]

scenario:coreapiscenario-core_dispatch_no_args_listeners

  • unstable execution_time [-235.744ns; +223.828ns] or [-8.835%; +8.388%]

scenario:coreapiscenario-core_dispatch_with_results_1_listener

  • unstable execution_time [-97.530ns; +88.819ns] or [-7.130%; +6.493%]

scenario:coreapiscenario-core_dispatch_with_results_50_listeners

  • unstable execution_time [-4486.176ns; +4786.539ns] or [-9.347%; +9.972%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • unstable execution_time [-849.321ns; +1050.638ns] or [-8.406%; +10.399%]

scenario:packagesupdateimporteddependencies-import_many_stdlib_cached

  • unstable execution_time [-54761.218ns; +53356.948ns] or [-9.711%; +9.462%]

Known flaky benchmarks

These benchmarks are marked as flaky and will not trigger a failure. Modify FLAKY_BENCHMARKS_REGEX to control which benchmarks are marked as flaky.

scenario:httppropagationinject-ids_only

  • 🟥 execution_time [+2.886µs; +3.003µs] or [+20.213%; +21.031%]

scenario:iastaspects-rstrip_aspect

  • 🟥 execution_time [+106.118µs; +111.360µs] or [+30.988%; +32.519%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+146.510µs; +150.939µs] or [+38.668%; +39.837%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+32.890µs; +35.824µs] or [+21.326%; +23.228%]

scenario:span-start

  • 🟥 execution_time [+1.342ms; +1.772ms] or [+10.787%; +14.246%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+221.683ns; +256.757ns] or [+11.601%; +13.436%]

scenario:tracer-small

  • 🟥 execution_time [+41.109µs; +42.256µs] or [+16.672%; +17.137%]

Known flaky benchmarks without significant changes:

  • scenario:errortrackingflasksqli-baseline
  • scenario:flasksimple-iast-get
  • scenario:iastaspects-casefold_aspect
  • scenario:iastaspects-casefold_noaspect
  • scenario:iastaspects-index_aspect
  • scenario:iastaspects-ljust_noaspect
  • scenario:iastaspects-lower_aspect
  • scenario:iastaspects-replace_aspect
  • scenario:iastaspects-swapcase_aspect
  • scenario:iastaspects-title_noaspect
  • scenario:iastaspects-translate_aspect
  • scenario:iastaspects-translate_noaspect
  • scenario:iastaspects-upper_noaspect
  • scenario:packagespackageforrootmodulemapping-cache_off
  • scenario:packagespackageforrootmodulemapping-cache_on
  • scenario:sethttpmeta-all-enabled
  • scenario:telemetryaddmetric-record-100-metrics

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 63b3fc6 into main Sep 29, 2026
876 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the brettlangdon/sccache-ignore-error branch September 29, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. ci-reliability The PR is related to the CI reliability of dd-trace-py MERGE-NOW

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants