test(appsec): migrate Stripe cassettes to test-agent VCR - #20618
florentinl wants to merge 2 commits into
Conversation
Codeowners resolved asResolved from the full PR diff against |
Dependency direction analysis
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: cc94ec6 | Docs | View more details | Give us feedback! |
Circular import analysis
|
BenchmarksBenchmark execution time: 2026-09-29 15:38:09 Comparing candidate commit cc94ec6 in PR branch Found 0 performance improvements and 8 performance regressions! Performance is the same for 606 metrics, 11 unstable metrics, 7 known flaky benchmarks, 17 flaky benchmarks without significant changes.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Description
Move AppSec Stripe tests from local vcrpy interception to the test agent's VCR proxy. Point both Stripe SDK entry points at the agent, register Stripe as a VCR provider, and replace 12 YAML cassettes with 13 agent cassettes. The suite now starts the test agent and no longer needs
no_proxyorvcrpy.The new cassette directory is owned by
@DataDog/asm-python. Test dependency locks were regenerated for the updated suite matrix. This is test and CI work only, so no release note is needed.Testing
scripts/run-testspassed all 22 Stripe tests in each of four Python 3.13 environments: latest Stripe, Stripe 11, Stripe 12, and Stripe 13 (88 test executions). The initial migration run used strict test-agent cassette replay; the final diff was rerun across all four environments.scripts/lint checkspassed.client_secretvalues remain redacted.Risks
The test agent names cassettes using the request path, method, and body. A future Stripe SDK encoding change may require an additional cassette. The current four Stripe variants replayed the migrated recordings successfully.
Additional Notes
No issue or JIRA ticket was provided for this test maintenance change.