Update excluded_substring_map to use setdefault and extend#158
Open
emmuhamm wants to merge 1 commit into
Open
Conversation
Author
|
Hi @bieryAtFnal, I've added this PR here to fix a small bug I encountered when running the PM integ test in drunc. Can you have a look at it? All relevant information should be in the desc. |
bieryAtFnal
approved these changes
May 28, 2026
Contributor
bieryAtFnal
left a comment
There was a problem hiding this comment.
This looks good to me. I ran a test in which I saw the expected (now corrected) behavior. Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is related to DUNE-DAQ/drunc#932, which came about from DUNE-DAQ/drunc#930
When fixing some of the new behaviour in drunc, I needed to add this line (see comment) to
ignored_logfile_problems.However, I noticed that this wasn't working because the relevant line in
src/integrationtest/log_file_checks.pyis continuously overriding this. This change fixes it to properly set a default as written there, but also to respect if others wanted to add their own stuff to ignore by appending the list.Type of change
Testing checklist
- [ ] Unit tests pass (e.g.dbt-build --unittest)pytest -s minimal_system_quick_test.py)- [ ] Full set of integration tests pass (dunedaq_integtest_bundle.sh)- [ ] Python tests pass if applicable (e.g.python -m pytest)- [ ] Pre-commit hooks run successfully if applicable (e.g.pre-commit run --all-files)Testing suggestion
This is tested with the relevant drunc PR. I recommend following the testing notes here DUNE-DAQ/drunc#933 to properly test the changes.
However, the minimal test that can be done is simply by running the msqt and seeing that nothing breaks.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))