Favorites System - #2676
Open
davocarli wants to merge 7 commits into
Open
Conversation
davocarli
marked this pull request as draft
August 14, 2026 13:52
davocarli
marked this pull request as ready for review
August 14, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
This PR lays the groundwork for a favorites system powered by a
favorites.iniin the universal library, then implements it in the Wood theme (the theme I use).Universal Groundwork:
favorites.cpplives in an opt-in source directory, to be reused across themes. It provides get/toggle functions plus a flag to indicate whether the last launch happened from favorites intended to be consumed on boot to restore the view.favorites.inistores the full paths of favorited files as a '|'-separated list (:is used elsewhere but cannot be used with full paths because of thesd:/andfat:/prefixes).Wood Theme Implementation:
chdirto the game's real directory, then restoring the previous directory as-needed.LASTVIEWflag in the ini.Where have you tested it?
melonDS in DSi mode, on a physical New 3DS XL running off the SD card, a physical DSi off the SD card, and on a DS Lite with an R4 clone cart from r4dsll.com. Built with the repo's Docker image.
Pull Request status