Skip to content

fix: Only auto-reload webapp in development mode#791

Merged
fstagni merged 1 commit intoDIRACGrid:integrationfrom
sfayer:fix_autoreload_dev_only
Apr 14, 2026
Merged

fix: Only auto-reload webapp in development mode#791
fstagni merged 1 commit intoDIRACGrid:integrationfrom
sfayer:fix_autoreload_dev_only

Conversation

@sfayer
Copy link
Copy Markdown
Member

@sfayer sfayer commented Apr 14, 2026

Hi,

The webapp has autoreload enabled if there is only one process: This causes it to stat all of the loaded files (hundreds of them, including all of the python site-package libraries) every second to see if they've changed. In the interests of efficiency, I'd like to suggest that this feature is only enabled in development mode (does anyone actually rely on it for their production instances?). Adding @marianne013 as a watcher.

Regards
Simon

BEGINRELEASENOTES
CHANGE: Only auto-reload webapp code in debug mode
ENDRELEASENOTES

@sfayer sfayer force-pushed the fix_autoreload_dev_only branch from cd13a8d to f148840 Compare April 14, 2026 13:29
Comment thread src/WebAppDIRAC/Core/App.py Outdated
Comment thread src/WebAppDIRAC/Core/App.py Outdated
@sfayer sfayer force-pushed the fix_autoreload_dev_only branch from e6f5d95 to 4f9ee65 Compare April 14, 2026 15:18
Co-authored-by: Federico Stagni <federico.stagni@cern.ch>
@sfayer sfayer force-pushed the fix_autoreload_dev_only branch from 4f9ee65 to a9d3c2b Compare April 14, 2026 15:19
@sfayer
Copy link
Copy Markdown
Member Author

sfayer commented Apr 14, 2026

Ah yes, that's what I get for manually typing out changes from the test node rather than copying a proper patch file :-)
Should all be fixed now...

Regards,
Simon

@fstagni fstagni merged commit 246ca98 into DIRACGrid:integration Apr 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants