Skip to content

01a0a06f - Count a bot auto-response as an answer in the open-ticket grouping - #1494

Merged
TaprootFreak merged 1 commit into
developfrom
01a0a06f-support-bot-reply-counts-as-answer
Sep 14, 2026
Merged

TaprootFreak merged 1 commit into
developfrom
01a0a06f-support-bot-reply-counts-as-answer

Conversation

@TaprootFreakAI

@TaprootFreakAI TaprootFreakAI commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

EN:
A ticket the support bot already answered no longer sits under Awaiting reply with a waiting badge. It is grouped as Answered and only returns to Awaiting reply when the customer writes again. Waiting hours and the overview escalation tiles follow the same rule. This takes over #1467 onto current develop.

DE:
Ein Ticket, auf das der Support-Bot schon geantwortet hat, steht nicht mehr unter Awaiting reply mit Warte-Badge. Es liegt unter Answered und kommt erst zurück, wenn der Kunde wieder schreibt. Wartezeit und Eskalations-Kacheln folgen derselben Regel. Das übernimmt #1467 auf den aktuellen develop.

Details

needsReply in src/util/support-stats.ts no longer treats AutoResponder as our turn. customerWaitingHours uses that function, so bot-answered tickets no longer show a waiting time. isUnassigned is unchanged (bot as clerk still renders Unassigned). Tickets without any message stay in Awaiting reply.

Tests: support-stats.test.ts (bot reply = answered, ticket returns on the next customer message, waiting timer null after a bot reply), support-issue-table.test.tsx (escalated badge sample now uses a customer message). The e2e/realunit-support.spec.ts grouping comment is updated; fixture data and assertions are unchanged.

Measured coverage on Node 20 for support-stats.ts and issue-table.tsx: 100/100/100/100 (46 tests). Declared: no Playwright baseline change (no rendered screen changes; the local seed has no bot-answered tickets).

Supersedes #1467 (same behaviour, rebased onto current develop).

A ticket the AutoResponder replied to last sat under Awaiting reply with
a waiting badge, although the customer already got an answer. It now sits
under Answered and only returns to Awaiting reply once the customer writes
again. Waiting hours and overview escalation tiles follow the same rule.
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

dfx pr guard

EN: Thanks for your contribution! This repository follows A38. A38 pass: author local-CI report accepted for this head.

DE: Danke für deinen Beitrag! In diesem Repository gilt A38. A38 pass: Autor-Local-CI-Report für diesen Head akzeptiert.

Details

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
The A38 report below records the checks, results and durations.

DE:
Der A38-Bericht unten dokumentiert die Prüfungen, Ergebnisse und Laufzeiten.

Details
Check / Prüfung Duration / Laufzeit Result / Ergebnis Exit code
lint: Lint and Markdown format 74 s pass 0

Durations rounded up to whole seconds / Laufzeiten auf ganze Sekunden aufgerundet.

Original report / Originalbericht
{
  "head": "c0219d3c96402d46e6394fa739d92b2362a18b00",
  "private": false,
  "recorded_at": "2026-09-14T16:17:25Z",
  "repo": "DFXswiss/app",
  "required": [
    "lint"
  ],
  "runs": [
    {
      "command": "agent a38 job commands --config '{\"env\":{\"CI\":\"true\"},\"npm\":{\"canaries\":[\"react-app-rewired/package.json\",\"react-scripts/package.json\",\"typescript/lib/typescript.js\",\"prettier/package.json\"],\"node_major\":20},\"steps\":[[\"npm\",\"run\",\"lint\"],[\"npm\",\"run\",\"format:md:check\"]]}'",
      "duration_s": 73.94543062499724,
      "exit_code": 0,
      "id": "lint",
      "name": "Lint and Markdown format",
      "result": "pass",
      "timeout_s": 600.0
    }
  ],
  "schema": "dfx-local-ci/v1"
}

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 1 review pass.
A bot auto-response now counts as an answer, so the ticket leaves Awaiting reply until the customer writes again.

DE:
Bereit nach 1 Review-Durchlauf.
Eine Bot-Antwort zählt als Antwort, das Ticket bleibt nicht mehr unter Awaiting reply, bis der Kunde wieder schreibt.

Details

Review: quality and logic, one pass, 0 findings at head c0219d3c. Coverage of src/util/support-stats.ts and src/components/support/issue-table.tsx measured 100/100/100/100 (Node 20, 46 tests). A38 light jobs pass (lint + format:md:check). GitHub checks on this head: Lint and Markdown format, Build and test, Full-stack E2E, review, CodeQL, dfx pr guard.

No Playwright baseline change (comment-only e2e grouping note; no rendered screen change). isUnassigned unchanged.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 14, 2026 16:26
@TaprootFreak
TaprootFreak merged commit 904a596 into develop Sep 14, 2026
13 checks passed
@TaprootFreak
TaprootFreak deleted the 01a0a06f-support-bot-reply-counts-as-answer branch September 14, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants