fix(compliance): keep field labels out of a copied value in the profile tables - #1458
Conversation
ba3e466 to
51657af
Compare
Blume1977
changed the title
|
@TaprootFreak bereit zum Review. Fork-PR, bitte das Label |
…le tables Dragging over a value in the compliance profile header or in the ticket's Account Data usually starts the selection in the label cell, so the copied text carried the cell boundary as a leading tab or space. The label cells are now non-selectable (select-none): a drag that starts in a label selects nothing, so the label can no longer end up in the clipboard. Values that are always copied as a whole select on a single click (select-all): the header's UserDataId, Name, VerifiedName, Mail, Organization and Ansprechsperson, and the mono InfoRow values (ids, hashes, IBANs). All other cells, including the KYC Status button, keep the default selection, so partial selection of an address or a comment still works. The header's never-used link branch (no field sets isLink/href) and its redundant re-entry guard (the button is disabled while a save runs) are removed; both were unreachable. New tests cover the shared info-panel building blocks and the header's personal and organization field sets.
51657af to
86fa093
Compare
A second click could fire onSetKycStatusCheck twice before React re-rendered isSettingKycStatus. Restore the synchronous ref guard without changing the copy/select-none behaviour.
Drop the unreachable isSaving check from the handler (the button is already disabled). Dispatch two clicks in one act so the test fails without the ref and stays at one confirm with it.
|
EN: DE: DetailsGrok quality and logic: 0 findings on HEAD |
…on review and user pages
…t-labels is CSS-only
|
EN: DE: DetailsThis pass re-checked the darwin baselines. Copy-without-labels is CSS ( |
3 participants
EN:
Profile table labels are no longer copied with the value. A second KYC-status click is blocked by a synchronous in-flight lock.
DE:
In den Profiltabellen wird das Label nicht mehr mit dem Wert kopiert. Ein zweiter Klick auf den KYC-Status wird durch eine synchrone In-Flight-Sperre blockiert.
Details
Click-to-copy uses
select-noneon labels andselect-allon identifier values. That CSS does not change pixels, so the existing darwin review-header baselines already match. The user-overview darwin file is unchanged for the same reason.The KYC in-flight
useRefis restored; the double-click unit test batches two clicks in oneact().Per-file coverage (Node 20,
CI=true npm test -- --coverage --collectCoverageFrom=…):src/components/compliance/compliance-review-header.tsxsrc/components/support/info-panel.tsx