Skip to content

01a09199 - Name the actual Draft reason in PR-Guard comments - #94

Merged
TaprootFreak merged 4 commits into
developfrom
feat/01a09199-lifecycle-comment-actual-reason
Sep 12, 2026
Merged

01a09199 - Name the actual Draft reason in PR-Guard comments#94
TaprootFreak merged 4 commits into
developfrom
feat/01a09199-lifecycle-comment-actual-reason

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
PR-Guard Draft comments now name the blockers that actually apply, instead of a canned CI-or-conflicts alternative.
The bot already computed the reason list; the visible sentence uses it.

DE:
Die sichtbaren Draft-Kommentare von PR-Guard nennen die Blocker, die tatsächlich vorliegen, statt einer CI-oder-Konflikte-Vorlage.
Die Gründe standen schon im Record; der sichtbare Satz verwendet sie.

Details

Visible EN/DE sentences for convert-to-draft and write-collaborator restore-Ready are built from record["reasons"]. Merge conflicts are mentioned only when that exact reason is present; CI/A38 phrases only when CI reasons exist. Distinct blockers are joined with "and"/"und", never "or"/"oder". The full list stays in the collapsed JSON details. The green Ready sentence is unchanged.

Covered cases include fork CI waiting for approval, A38 not green, merge conflicts only, and both conflicts and failed CI.

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 3 review passes.
PR-Guard Draft comments now name the blockers that actually apply instead of a canned CI-or-conflicts alternative.

DE:
Bereit nach 3 Review-Durchläufen.
Die sichtbaren Draft-Kommentare von PR-Guard nennen die Blocker, die tatsächlich vorliegen, statt einer CI-oder-Konflikte-Vorlage.

Details

Review: Grok quality and logic, then Codex quality and logic, on head d7aec642d5da8f3c32a4cba1e32c3d13e7021522. Passes 1 and 2 each had Codex findings that were fixed on this head (mixed CI failure with A38; cancelled phrased as failed; A38 matched only via A38 / report (). Pass 3: 0 findings, STATUS complete on all four lanes.

Visible Draft/restore sentences are built from record["reasons"]. Distinct blockers join with "and"/"und", never "or"/"oder". The full list stays in collapsed JSON details.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 11, 2026 22:16
@TaprootFreak
TaprootFreak merged commit 278732b into develop Sep 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants