Skip to content

01a0855d - Require contents write for Guard Ready mutations - #92

Merged
TaprootFreak merged 5 commits into
developfrom
fix/01a0855d-guard-contents-write
Sep 11, 2026
Merged

01a0855d - Require contents write for Guard Ready mutations#92
TaprootFreak merged 5 commits into
developfrom
fix/01a0855d-guard-contents-write

Conversation

@TaprootFreakAI

Copy link
Copy Markdown
Collaborator

EN:
dfx pr guard's GITHUB_TOKEN must have contents: write so markPullRequestReadyForReview can leave draft. HTTP 200 with unchanged isDraft is now an explicit error.

DE:
Der GITHUB_TOKEN von dfx pr guard braucht contents: write, damit markPullRequestReadyForReview den Draft aufhebt. HTTP 200 ohne Änderung an isDraft ist jetzt ein expliziter Fehler.

Details

Fork PR DFXswiss/backend#5465: Guard decided Ready, then _transition raised PR lifecycle mutation failed (HTTP 200). GraphQL with the author token set isDraft: false; the Actions token did not. The documented GitHub requirement is contents: write.

@TaprootFreakAI

TaprootFreakAI commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator Author

EN:
Ready after 1 review pass.
dfx pr guard's GITHUB_TOKEN must have contents: write so markPullRequestReadyForReview can leave draft.

DE:
Bereit nach 1 Review-Durchlauf.
Der GITHUB_TOKEN von dfx pr guard braucht contents: write, damit markPullRequestReadyForReview den Draft aufhebt.

Details

Head 5443b8ffdf67f714af5e7ecbc8107b036478b9d5 rebased onto current develop (incl. agent#93 REST draft re-read). Mergeable. Pytest SUCCESS (GitHub run 34619139731). Lifecycle tests 77 passed on the build host.

Comment gate: this wrap-up only. No review threads.

HTTP 200 with unchanged isDraft is an explicit error naming contents: write. GraphQL error messages are included. REST confirmation after GraphQL success remains.

Codex quality noted a missing period on the tip commit subject (pre-existing on the previously ready #92; rebase kept it). Codex logic noted falsey empty errors objects; GitHub sends a non-empty array, already fail-closed. Neither counted.

@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 10, 2026 22:18
@TaprootFreakAI
TaprootFreakAI marked this pull request as draft September 11, 2026 15:55
@TaprootFreakAI
TaprootFreakAI force-pushed the fix/01a0855d-guard-contents-write branch from d3e9094 to 5443b8f Compare September 11, 2026 15:57
@TaprootFreakAI
TaprootFreakAI marked this pull request as ready for review September 11, 2026 16:07
@TaprootFreak
TaprootFreak merged commit d6b4724 into develop Sep 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants