Repository navigation
Edge cases of geckopy agree with GECKO - #78
Merged
Merged
Conversation
The order no longer depends on the shadow price, which depends on the basis at a degenerate optimum. Enzymes at their bound are solved again with the bound raised by fold_change; multiple_active marks rows where another capacity constraint is active.
…and requires a fold_change above 1
…at objective best_parsimonious ignores points with a NaN rmse, screen_kcat_leverage sorts stably, cmaes_kcat_tuning does not stop on a flat generation, and compute_excarbon warns for a model without metabolite formulas.
…e_usage rejects a negative top_abs_usage
…mics_greedy, apply_complex_data and add_new_rxns_to_ec
…field with an opening quote and no closing one
…e rows in the order of model.ec.rxns
…out a product as exchange reactions
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
The default description is written only when the model has none, as saveEcModel does.
# Conflicts: # CHANGELOG.md
…f a usage reaction
…d constrain_enz_concs
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Tests cover the round trip, the saved text and the light tutorial ecModel. The format page and the docstrings describe the optional enzymes entry.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where geckopy and GECKO gave different results for the same input, both now behave alike. Invalid input raises, data that cannot apply to an item is skipped with a warning, and an explicitly empty list selects nothing. Each change has a test, and the CHANGELOG lists them.
read_kcat_sourceValueErrorread_dlkcat_output,write_dlkcat_inputec.rxnsorderECTree,kcats_from_ec_treek = NaNraises; an emptyec_rxnsgives an empty list; a repeated reaction counts onceassign_standard_kcatreview_assignment,EcStats,ec_stats_from_brendageckopy.gather_kcatsandgeckopy; the sourcescustomandstandardcompare in any casefind_met_smilesscreen_kcat_leverage,compute_excarbonbest_parsimonious,cmaes_kcat_tuningcma's flat-fitness criteriageckopy.kcat_tuning.evotunebest_parsimonious,n_changed,parsimony_frontierandisozyme_tie_mapec_fseoffill_enz_concs,constrain_enz_concsload_flux_data,report_enzyme_usage,enzyme_usagetop_abs_usageraises; an enzyme without a usage reaction is left out with a warningapply_kcat_constraintspfba_enzymesfraction_of_optimumis multiplied by 0.999999, as the default issave_ec_modelenzymesentry (the readers still accept the older forms); an existing metaData description is keptDepends on CompMetEng/raven-toolbox for the writer of the
ec-rxnssection and for the reader that turns GECKO 3 protein reactions forward. Parity: CompMetEng/raven-gecko-parity ledger and scenarios.