fix: ignore any uv.toml file#1725
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR adds ChangesUV Hermetic Configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Prevents user/system settings in a uv.toml file from interfering with installation and resolution of dependencies. See Comfy-Org#1722.
d5f2f31 to
833997a
Compare
Summary
UV_NO_CONFIG=1in the bundled uv's environment so user/systemuv.tomlfiles (e.g.~/.config/uv/uv.toml) cannot influence dependency resolution.uvEnv.UV_NO_CONFIG === '1'.Closes #1722.
Root cause
The bundled
uvbinary still performs uv's normal config discovery — user config at~/.config/uv/uv.toml, system config, and project-leveluv.toml/[tool.uv]. Settingexclude-newerin my personaluv.tomlapplied that constraint everyuv pip installanduv pip install --dry-run(the latter is whathasRequirements()runs to verify the venv), causing dependency resolution / verification to fail.The desktop app already passes all needed configuration to uv via CLI args (
--index-url,--python-preference,--index-strategy, etc.) and env vars (UV_PYTHON_INSTALL_MIRROR), so ignoringuv.tomlconfig files shouldn't be an issue. Note: if a project-level uv config file is ever used instead of CLI args, then this fix would interfere with that.Test plan
yarn lintyarn typecheckyarn test:unit(351 + 1 new test passing)yarn makeand ran the app: venv creation and requirements installation completed cleanly while the offending useruv.tomlwas in place.Summary by CodeRabbit
Release Notes