Skip to content

Add show_version_updates CLI feature flag#14646

Open
Kosinkadink wants to merge 1 commit into
masterfrom
feature/show-version-updates-flag
Open

Add show_version_updates CLI feature flag#14646
Kosinkadink wants to merge 1 commit into
masterfrom
feature/show-version-updates-flag

Conversation

@Kosinkadink

Copy link
Copy Markdown
Member

Registers a show_version_updates bool feature flag (default true) in CLI_FEATURE_FLAG_REGISTRY.

This lets a launcher discover the flag via --list-feature-flags and set it via --feature-flag show_version_updates=<bool>, which propagates into SERVER_FEATURE_FLAGS and is sent to the frontend. The frontend uses it to seed the default of its Comfy.Notification.ShowVersionUpdates setting (the user setting still overrides).

When the flag is not passed, it is absent from the server features and the frontend falls back to its own default, so behavior is unchanged for non-launcher runs.

Part of a 3-repo change for Comfy-Org/Comfy-Desktop#1194:

  • Comfy-Org/ComfyUI (this PR) — register the flag
  • Comfy-Org/ComfyUI_frontend — read the flag as the setting default
  • Comfy-Org/Comfy-Desktop — inject the flag from a settings toggle

Registers a show_version_updates bool flag (default true) in CLI_FEATURE_FLAG_REGISTRY so launchers can override the frontend default for new-release/version-update notifications via --feature-flag.

Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035
Co-authored-by: Amp <amp@ampcode.com>
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5facbfad-4ed3-4126-abd4-5dfa7193d7e0

📥 Commits

Reviewing files that changed from the base of the PR and between 7cb784e and 9c0f668.

📒 Files selected for processing (1)
  • comfy_api/feature_flags.py

📝 Walkthrough

Walkthrough

CLI_FEATURE_FLAG_REGISTRY in comfy_api/feature_flags.py now includes a new boolean flag named show_version_updates. The entry sets the default to True and adds description text indicating it controls frontend new-release/version-update notifications, while still allowing the user setting to override it.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly names the new CLI feature flag added by this PR.
Description check ✅ Passed The description accurately explains the new flag and its role in launcher/frontend behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant