Add show_version_updates CLI feature flag#14646
Open
Kosinkadink wants to merge 1 commit into
Open
Conversation
Registers a show_version_updates bool flag (default true) in CLI_FEATURE_FLAG_REGISTRY so launchers can override the frontend default for new-release/version-update notifications via --feature-flag. Amp-Thread-ID: https://ampcode.com/threads/T-019f0347-dc00-723a-a4d2-558539329035 Co-authored-by: Amp <amp@ampcode.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a
show_version_updatesbool feature flag (defaulttrue) inCLI_FEATURE_FLAG_REGISTRY.This lets a launcher discover the flag via
--list-feature-flagsand set it via--feature-flag show_version_updates=<bool>, which propagates intoSERVER_FEATURE_FLAGSand is sent to the frontend. The frontend uses it to seed the default of itsComfy.Notification.ShowVersionUpdatessetting (the user setting still overrides).When the flag is not passed, it is absent from the server features and the frontend falls back to its own default, so behavior is unchanged for non-launcher runs.
Part of a 3-repo change for Comfy-Org/Comfy-Desktop#1194: