Skip to content

[Partner Nodes] feat(Grok): add 1080p resolution to Grok Image node#14612

Merged
bigcat88 merged 2 commits into
masterfrom
feat/api-nodes/Grok-Imagine
Jun 24, 2026
Merged

[Partner Nodes] feat(Grok): add 1080p resolution to Grok Image node#14612
bigcat88 merged 2 commits into
masterfrom
feat/api-nodes/Grok-Imagine

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Also we will switch from grok-imagine-video-1.5-preview to the grok-imagine-video-1.5 model ID. Second try.

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The changes update GrokVideoNode in comfy_api_nodes/nodes_grok.py across four areas. The API model ID for grok-imagine-video-1.5 is corrected from a -preview variant to "grok-imagine-video-1.5". The resolution schema input gains 1080p as a selectable option with a tooltip noting it is exclusive to that model. The price_badge formula is revised to include 1080p-specific rate logic, an updated image cost calculation for the 1.5 model, and an inputs.image.connected-conditional total. Finally, execute gains a validation check that raises ValueError when 1080p is selected with any model other than grok-imagine-video-1.5.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title captures the main 1080p resolution addition, though it mislabels the node as Image instead of Video.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description matches the changeset by mentioning the Grok model ID switch and pricing update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@comfy_api_nodes/nodes_grok.py`:
- Around line 573-578: The price badge logic in the Grok image/video pricing
expression is undercounting the mandatory 1.5 image input because it only adds
$imgCost when inputs.image is connected. Update the pricing calculation near the
widgets.resolution and $imgCost logic so grok-imagine-video-1.5 always includes
the image input cost in the displayed USD total, regardless of connection state,
while preserving the existing resolution/duration rate handling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2d547ca4-b284-4bb9-b5fd-2ad123c8cd95

📥 Commits

Reviewing files that changed from the base of the PR and between 44955d7 and c7f5744.

📒 Files selected for processing (1)
  • comfy_api_nodes/nodes_grok.py

Comment thread comfy_api_nodes/nodes_grok.py
@bigcat88 bigcat88 merged commit cabb734 into master Jun 24, 2026
22 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/Grok-Imagine branch June 24, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants