Skip to content

[Partner Nodes] feat(Alibaba): add support for HappyHorse 1.1 model#14611

Merged
bigcat88 merged 2 commits into
masterfrom
feat/api-nodes/HappyHorse-1.1
Jun 24, 2026
Merged

[Partner Nodes] feat(Alibaba): add support for HappyHorse 1.1 model#14611
bigcat88 merged 2 commits into
masterfrom
feat/api-nodes/HappyHorse-1.1

Conversation

@bigcat88

@bigcat88 bigcat88 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Second try to add support for a new version of HappyHorse

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto‑billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

Signed-off-by: bigcat88 <bigcat88@icloud.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

comfy_api_nodes/nodes_wan.py adds two image-validation utilities to its import list and extends three Wan video-generation nodes with HappyHorse 1.1 model variants. HappyHorseTextToVideoApi, HappyHorseImageToVideoApi, and HappyHorseReferenceVideoApi each gain a new happyhorse-1.1-* model branch in define_schema, with the Reference node also receiving expanded ratio choices and an autogrow input. The price_badge calculation in all three nodes is updated to apply a different per-resolution PPS table when the selected model contains "1.1". In the execute methods of the Image-to-Video and Reference Video nodes, input images are now validated for minimum dimensions and allowable aspect ratio before any upload or media construction occurs. The error message for missing reference images is also updated.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding HappyHorse 1.1 support under Alibaba partner nodes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly matches the changes: adding support for a new HappyHorse version.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bigcat88 bigcat88 merged commit 44955d7 into master Jun 24, 2026
17 checks passed
@bigcat88 bigcat88 deleted the feat/api-nodes/HappyHorse-1.1 branch June 24, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants