Skip to content

N°9128 - Update CKEditor5 to v48#889

Draft
steffunky wants to merge 1 commit intodevelopfrom
feature/9128_update_ckeditor5
Draft

N°9128 - Update CKEditor5 to v48#889
steffunky wants to merge 1 commit intodevelopfrom
feature/9128_update_ckeditor5

Conversation

@steffunky
Copy link
Copy Markdown
Member

Base information

Question Answer
Related to a SourceForge thread / Another PR / Combodo ticket? N°9128
Type of change? Enhancement

Objective (enhancement)

Update CKEditor 5 from v41.4 to v48.0

Proposed solution (bug and enhancement)

Follow CKEditor v48 upgrade guide, only import CKEditor5 npm package, remove most of webpack use (we still need it to get a build), replace our custom Maximize plugin with the new default Fullscreen plugin
Adapt changes required in iTop's code
Fix issues due to bad SCSS

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested all changes I made on an iTop instance
  • Would a unit test be relevant and have I added it?
  • Is the PR clear and detailed enough so anyone can understand without digging in the code?

Checklist of things to do before PR is ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Work made by Combodo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants