London | 25-ITP-May | Giorgi Natriashvili | Sprint 2 | Wireframe#1253
London | 25-ITP-May | Giorgi Natriashvili | Sprint 2 | Wireframe#1253Giontr wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Giontr
added
Needs Review
There was a problem hiding this comment.
Code looks good and well formatted. Page layout matches the wireframe well.
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
| <p class="content"> | ||
| Typically named README.md and written in Markdown, it lives at the root of a repository and renders automatically on platforms like GitHub. Its core purpose is to answer three questions immediately: what does this project do, how do I get it running, and how do I use it?<br>A well-crafted README... | ||
| </p> |
There was a problem hiding this comment.
Lines 23-25 can be better formatted as:
<p class="content">
Typically named README.md and written in Markdown, it lives at the root
of a repository and renders automatically on platforms like GitHub. Its core
purpose is to answer three questions immediately: what does this project do,
how do I get it running, and how do I use it?<br>A well-crafted README...
</p>
To understand why, you can ask AI these questions:
- How HTML treats multiple whitespace characters in text?
- What's the advantage of not writing a long paragraph of text in a single line in HTML?
VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text. You can refer to this guide for more info about enabling "Format on Save" in VS Code or using VS Code's "Format Document" feature.
There was a problem hiding this comment.
Thanks, I changed paragraph format and fixed footer to the bottom too.
There was a problem hiding this comment.
Why not use the VS Code's formatter?
If you are using a formatter, all paragraphs would also be updated automatically.
There was a problem hiding this comment.
I had extension prettier as formatter however I didn't knew I have to format it manually
There was a problem hiding this comment.
If you also enable "Format on save" and "Format on paste", then the code will be formatted automatically (unless there are syntax errors in the code).
cjyuan
added
Reviewed
Giontr
added
the
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Good job in making the footer fixed at the bottom. Current, the content of the footer and the content of the articles can overlap. Can you address this issue?
| <p class="content"> | ||
| Typically named README.md and written in Markdown, it lives at the root of a repository and renders automatically on platforms like GitHub. Its core purpose is to answer three questions immediately: what does this project do, how do I get it running, and how do I use it?<br>A well-crafted README... | ||
| </p> |
There was a problem hiding this comment.
Why not use the VS Code's formatter?
If you are using a formatter, all paragraphs would also be updated automatically.
cjyuan
removed
the
Needs Review
|
Changes look good. Well done. |
cjyuan
added
Complete
2 participants
Self checklist
Changelist
Created 3 article, each with own Header, Paragraph, and images.