Repository navigation
ChromaDotNet.VectorData 0.4.0 - #4
Merged
Merged
Conversation
…rs 0.1.6 ChromaVectorStore takes ownsClient: each sample and test gives the vector store the ChromaClient it creates for it. The hybrid search sample no longer sets CreateBm25Indexes, which is gone: on Chroma Cloud the collection gets a BM25 index for the full-text indexed property when it is created.
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
No concrete defects were identified, but dependency compatibility and Chroma Cloud BM25 behavior still require integration validation.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Semantic Kernel samples and tests for ChromaDotNet.VectorData 0.4.0 and explicit client ownership.
Changes:
- Upgrades VectorData to 0.4.0 and Testcontainers to 0.1.6.
- Adds
ownsClient: truewhere vector stores receive dedicated clients. - Removes
CreateBm25Indexesand clarifies automatic BM25 indexing on Chroma Cloud.
| File | Description |
|---|---|
| test/ChromaDB.SemanticKernel.Sample.Tests/MultiStoreTests.cs | Transfers client ownership to the store. |
| test/ChromaDB.SemanticKernel.Sample.Tests/DataModelAndPagingTests.cs | Updates test-store client ownership. |
| test/ChromaDB.SemanticKernel.Sample.Tests/ChromaDB.SemanticKernel.Sample.Tests.csproj | Upgrades Testcontainers. |
| test/ChromaDB.SemanticKernel.Sample.Tests/ChatCompletionRagTests.cs | Updates test-store client ownership. |
| samples/GettingStartedWithTextSearch/GettingStartedWithTextSearch.csproj | Upgrades both Chroma packages. |
| samples/GettingStartedWithTextSearch/ChromaVectorStoreFixtureBase.cs | Sets fixture-store client ownership. |
| samples/Concepts/Memory/VectorStore_VectorSearch_Paging_Chroma.cs | Sets paging-store client ownership. |
| samples/Concepts/Memory/VectorStore_VectorSearch_MultiStore_Chroma.cs | Sets non-DI store client ownership. |
| samples/Concepts/Memory/VectorStore_HybridSearch_Simple_Chroma.cs | Removes indexing option and sets ownership. |
| samples/Concepts/Memory/VectorStore_DynamicDataModel_Interop_Chroma.cs | Sets ownership in both interop examples. |
| samples/Concepts/Concepts.csproj | Upgrades VectorData. |
| samples/Concepts/Agents/ChatCompletion_Rag_Chroma.cs | Sets ownership in both RAG examples. |
| samples/Concepts/Agents/ChatCompletion_Rag_Chroma_Ollama.cs | Sets ownership in both Ollama examples. |
| README.md | Clarifies Chroma Cloud indexing behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChromaVectorStoretakesownsClient: each sample and test gives the vector store theChromaClientit creates for it (ownsClient: true).VectorStore_HybridSearch_Simple_Chromano longer setsCreateBm25Indexes, which is gone: on Chroma Cloud, the collection gets a BM25 index for the full-text indexed property when it is created. The README says so.