Repository navigation
Delete with three characters in the test of a delete by ids with a filter on the documents, as Chroma Cloud needs since KD-57 - #134
Merged
Conversation
…lter on the documents, as Chroma Cloud needs since KD-57
There was a problem hiding this comment.
🟢 Approval recommended
The focused test update preserves its intent and correctly addresses the documented Chroma Cloud constraint.
0 open findings
What changed in this PR
Updates a deletion test to remain compatible with Chroma Cloud’s three-character minimum for $contains.
Changes:
- Replaces
"2"with"oc2"while preserving document distinction. - Documents the KD-57 compatibility requirement.
| File | Description |
|---|---|
ChromaDB.Client.Tests/CollectionClientCUDTests.cs |
Uses a three-character document filter in the deletion test. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AnisaHaxhialushi
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DeleteByMultipleIdsWithWhereDocumentdeletes the recordsDoc1andDoc2by ids with$containsof the last character ofDoc2. On Chroma Cloud a text of fewer than 3 characters throws anArgumentExceptionbefore the request (KD-57), so the test fails there, onmaintoo; the CI does not run on Chroma Cloud. This changes the test only, as the tests of contains before."2", and the test failed on Chroma Cloud with the error of KD-57."oc2", which tell the two documents apart as before, on every server.