Skip to content

Delete with three characters in the test of a delete by ids with a filter on the documents, as Chroma Cloud needs since KD-57 - #134

Merged
Laurianti merged 1 commit into
mainfrom
cud-contains-test
Oct 13, 2026
Merged

Laurianti merged 1 commit into
mainfrom
cud-contains-test

Conversation

@Laurianti

Copy link
Copy Markdown
Member

DeleteByMultipleIdsWithWhereDocument deletes the records Doc1 and Doc2 by ids with $contains of the last character of Doc2. On Chroma Cloud a text of fewer than 3 characters throws an ArgumentException before the request (KD-57), so the test fails there, on main too; the CI does not run on Chroma Cloud. This changes the test only, as the tests of contains before.

  • Before: the delete filtered with "2", and the test failed on Chroma Cloud with the error of KD-57.
  • Now: it filters with the last three characters, "oc2", which tell the two documents apart as before, on every server.
  • Tests: the test passes on Chroma Cloud, 1.5.9, 0.6.3 and 0.4.23 on the v1 API.

…lter on the documents, as Chroma Cloud needs since KD-57
@Laurianti
Laurianti requested a review from a team as a code owner October 13, 2026 17:14
Copilot AI balanced review requested due to automatic review settings October 13, 2026 17:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test update preserves its intent and correctly addresses the documented Chroma Cloud constraint.

0 open findings

What changed in this PR

Updates a deletion test to remain compatible with Chroma Cloud’s three-character minimum for $contains.

Changes:

  • Replaces "2" with "oc2" while preserving document distinction.
  • Documents the KD-57 compatibility requirement.
File Description
ChromaDB.Client.Tests/​CollectionClientCUDTests.cs Uses a three-character document filter in the deletion test.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Laurianti
Laurianti merged commit 7a32cb0 into main Oct 13, 2026
16 checks passed
@Laurianti
Laurianti deleted the cud-contains-test branch October 13, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants