refactor(descriptions): remove pkg/descriptions and related CLI flag - #8092
Open
cx-ricardo-jesus wants to merge 8 commits into
Open
refactor(descriptions): remove pkg/descriptions and related CLI flag#8092cx-ricardo-jesus wants to merge 8 commits into
cx-ricardo-jesus wants to merge 8 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
cx-ricardo-jesus
marked this pull request as ready for review
July 28, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
Proposed Changes
pkg/descriptions.pkg/scan/client.gothat checks if the current KICS version is up-to-date by querying the GitHub releases API. It early returns assuming it's the latest if the version is "development", an HTTP request fails, a 404 response is returned, or other errors occur reading the API response. Otherwise compares the local version against the tag_name from the release response.I submit this contribution under the Apache-2.0 license.