Skip to content

refactor(descriptions): remove pkg/descriptions and related CLI flag - #8092

Open
cx-ricardo-jesus wants to merge 8 commits into
masterfrom
AST-133282
Open

refactor(descriptions): remove pkg/descriptions and related CLI flag#8092
cx-ricardo-jesus wants to merge 8 commits into
masterfrom
AST-133282

Conversation

@cx-ricardo-jesus

@cx-ricardo-jesus cx-ricardo-jesus commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Reason for Proposed Changes

  • Currently the descriptions package, does not fetch any cis_descriptions.

Proposed Changes

  • Removed E2E test 046, since the purpose of this unit test is to simulate the --disable-full-descriptions, flag doesn't make sense to have it since the descriptions package has been removed.
  • Renamed the E2E tests to be ordered, since one of them was removed.
  • Removed any reference to the --disable-full-descriptions flag on kics documentation.
  • Fully removed pkg/descriptions.
  • Implemented a new function inside pkg/scan/client.go that checks if the current KICS version is up-to-date by querying the GitHub releases API. It early returns assuming it's the latest if the version is "development", an HTTP request fails, a 404 response is returned, or other errors occur reading the API response. Otherwise compares the local version against the tag_name from the release response.

I submit this contribution under the Apache-2.0 license.

@stepsecurity-app

This comment was marked as outdated.

@stepsecurity-app

This comment was marked as outdated.

@cx-ricardo-jesus
cx-ricardo-jesus marked this pull request as ready for review July 28, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant