Repository navigation
Align byte detection batching with stream detection - #237
Open
Sinkleberg wants to merge 1 commit into
Open
Sinkleberg wants to merge 1 commit into
Sinkleberg wants to merge 1 commit into
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149. Feed byte arrays and spans in the same 1024-byte batches used by stream detection, stopping when the detector has a confident result. Document that this samples input rather than validating every byte.
A UTF-8 prefix followed by a late invalid byte now gives the same result through stream, array, span, and offset APIs. Added controls for valid emoji, chunk boundaries, async streams, BOMs, slices, empty input, and null arrays.
The identical regression fixture fails three cases on the original source. All 238 tests pass on Windows with .NET 10 and .NET Framework 4.8.1; the multi-target Release build and symbol package pass. Linux/macOS, .NET 8/9 test runs, and the separate hosted NuGet metadata validator were not run.