Skip to content

chore: standardize enterprise Dependabot configuration - #548

Closed
somethingwithproof wants to merge 5 commits into
Cacti:developfrom
somethingwithproof:chore/dependabot-config
Closed

somethingwithproof wants to merge 5 commits into
Cacti:developfrom
somethingwithproof:chore/dependabot-config

Conversation

@somethingwithproof

Copy link
Copy Markdown
Member

Adds grouped, cooled-down Dependabot updates with standard ecosystem labels and commit prefixes.

Copilot AI review requested due to automatic review settings July 14, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds repository automation configuration under .github/ to manage dependency update PRs and introduce CodeQL code scanning.

Changes:

  • Add a new CodeQL GitHub Actions workflow to analyze a language matrix on pushes/PRs/schedule.
  • Add a new Dependabot configuration to group GitHub Actions updates, apply labels, set commit message prefixing, and apply a cooldown.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/codeql.yml Introduces a CodeQL workflow (currently has workflow-expression issues that will break runs).
.github/dependabot.yml Adds grouped Dependabot updates for GitHub Actions targeting the develop branch with labels and commit message conventions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
Comment thread .github/workflows/codeql.yml Outdated
@somethingwithproof
somethingwithproof force-pushed the chore/dependabot-config branch from def4f8e to ef73d62 Compare July 29, 2026 05:36
@somethingwithproof

Copy link
Copy Markdown
Member Author

Folded into #550, which now carries the Dependabot config alongside the Rocky Linux job. Both are CI plumbing and read as one decision.

Closing this one.

@somethingwithproof
somethingwithproof deleted the chore/dependabot-config branch August 30, 2026 07:06
netniV pushed a commit that referenced this pull request Aug 31, 2026
Two pieces of CI plumbing, grouped so they are one review rather than
two.

**Rocky Linux 9 job.** EL is the primary deployment platform and nothing
in CI covered it. The job as originally written could never have passed:
`libtirpc-devel` is not in the Rocky 9 default repos, so `dnf install`
aborted the whole transaction and every later step was skipped. Removed
it — the build does not need it. Verified by running the full workflow
body in a `rockylinux:9` container: install, configure, make and check
all pass, 39 warnings.

Image pinned by digest. `set -euo pipefail` added so it satisfies the
workflow policy check in #541. Added a `pull_request` trigger with a
`paths` filter so a change that breaks the EL9 build is caught on the
PR, not on the following Saturday's cron.

**Dependabot.** `github-actions` plus `docker` — the repo has
`Dockerfile`, `Dockerfile.dev` and the snmpd fixture image, none of
which were tracked.

Was #548, folded in here.

**CI hardening added**
- `concurrency` with `cancel-in-progress` — a PR push previously ran the
whole workflow twice and never cancelled stale runs.
- `timeout-minutes: 20` on every job; a hung build otherwise holds a
runner for six hours.
- An ASan/UBSan job. Spine is a threaded network daemon and had no
sanitizer coverage at all.
- `make -j"$(nproc)"` in place of unbounded `make -j`.

---------

Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants