Skip to content

ci: pin integration tests to Cacti 1.2.31 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
somethingwithproof wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

ci: pin integration tests to Cacti 1.2.31 #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da1b99c
ci: pin integration tests to Cacti 1.2.31
somethingwithproof Jul 13, 2026
d02ad10
Use runner PHP without versioned Apache package
somethingwithproof Jul 14, 2026
dd78637
ci: tolerate missing phpstan/lint tooling on Cacti 1.2.31
somethingwithproof Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions .github/workflows/plugin-ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: Cacti/cacti
ref: release/1.2.31
path: cacti

- name: Checkout mactrack Plugin
Expand All @@ -85,7 +86,7 @@ jobs:
run: sudo apt-get update

- name: Install System Dependencies
run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping libapache2-mod-php${{ matrix.php }}
run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping

- name: Start SNMPD Agent and Test
run: |
Expand Down Expand Up @@ -182,24 +183,40 @@ jobs:
- name: Check PHP Syntax for Plugin
run: |
cd ${{ github.workspace }}/cacti/plugins/mactrack
if find . -name '*.php' -exec php -l {} 2>&1 \; | grep -iv 'no syntax errors detected'; then
echo "Syntax errors found!"
exit 1
fi

find . -path './vendor' -prune -o -name '*.php' -print0 | xargs -0 -n1 php -l

# Cacti 1.2.31 has no .phpstan.neon / lint scripts; only touch them when present.
- name: Remove the plugins directory exclusion from the .phpstan.neon
run: sed '/plugins/d' -i .phpstan.neon
run: |
if [ -f .phpstan.neon ]; then
sed '/plugins/d' -i .phpstan.neon
else
echo '.phpstan.neon not present; skipping'
fi
working-directory: ${{ github.workspace }}/cacti

- name: Mark composer scripts executable
run: sudo chmod +x ${{ github.workspace }}/cacti/include/vendor/bin/*
run: |
if [ -d "${{ github.workspace }}/cacti/include/vendor/bin" ]; then
sudo find "${{ github.workspace }}/cacti/include/vendor/bin" -maxdepth 1 -type f -exec chmod +x {} +
fi

- name: Run Linter on base code
run: composer run-script lint ${{ github.workspace }}/cacti/plugins/mactrack
run: |
if composer run-script --list | grep -qE '^ lint'; then
composer run-script lint ${{ github.workspace }}/cacti/plugins/mactrack
else
echo 'Composer lint script is not defined; skipping.'
fi
working-directory: ${{ github.workspace }}/cacti

- name: Checking coding standards on base code
run: composer run-script phpcsfixer ${{ github.workspace }}/cacti/plugins/mactrack
run: |
if composer run-script --list | grep -qE '^ phpcsfixer'; then
composer run-script phpcsfixer ${{ github.workspace }}/cacti/plugins/mactrack
else
echo 'Composer phpcsfixer script is not defined; skipping.'
fi
working-directory: ${{ github.workspace }}/cacti

# - name: Run PHPStan at Level 6 on base code outside of Composer due to technical issues
Expand Down
Loading