Skip to content

chore(UI): Properly indent menus#8617

Merged
SenkJu merged 1 commit into
nextgenfrom
fix-menu-ident
Jul 7, 2026
Merged

chore(UI): Properly indent menus#8617
SenkJu merged 1 commit into
nextgenfrom
fix-menu-ident

Conversation

@SenkJu

@SenkJu SenkJu commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

A previous change left the menu code not indented properly.

@SenkJu SenkJu merged commit 9e7b00e into nextgen Jul 7, 2026
3 checks passed
@SenkJu SenkJu deleted the fix-menu-ident branch July 7, 2026 16:32
@SenkJu SenkJu added this to the 0.39.0 milestone Jul 7, 2026
@liquidbounce-support-bot

Copy link
Copy Markdown

Thanks for cleaning this up, @SenkJu! Pure indentation fix, looks straightforward.

One small thing the diff misses: in Multiplayer.svelte, the ternary continuation lines under image={...} still carry their old indentation, so they no longer line up with the now-dedented image= attribute:

        <MenuListItem imageText={server.ping > 0 ? `${server.ping}ms` : null}
                      imageTextBackgroundColor={getPingColor(server.ping)}
                      image={server.ping < 0 || !server.icon
                        ? `${REST_BASE}/api/v1/client/resource?id=minecraft:textures/misc/unknown_server.png`
                        :`data:image/png;base64,${server.icon}`}

Might be worth realigning those too while you're in there. Otherwise LGTM — leaving the actual review to the team.


🤖 Automated support reply — a human maintainer will review if this doesn't help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant