You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the refactor, @MukjepScarlet! A couple of things worth a look before a maintainer reviews:
scanChunkSections no longer awaits the section scans. The old code collected the jobs and .joinAll()ed them, so the suspend fun only returned once every section had been scanned. The new version wraps the loop in coroutineScope { … } but still launches each job on the object-level scope (scope.launch { … }), so those coroutines aren't children of the coroutineScope and aren't awaited — the function returns as soon as the loop finishes dispatching. If the intent is to keep the join behaviour, launch on the coroutineScope receiver (or collect + joinAll); if fire-and-forget is intended, the coroutineScope wrapper is a no-op and can go.
The ChunkLoad change is broader than the title. Adding it.clearChunk(chunk.pos) before chunkUpdate (for the replaced-chunk case) is a behaviour change beyond "skip empty chunk section" — might be worth calling out in the PR description so reviewers don't miss it.
Everything else (the hasOnlyAir() skip and the suspend (CoroutineScope) -> Unit interface) reads cleanly. Leaving the real review to the maintainers.
🤖 Automated support reply — a human maintainer will review if this doesn't help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.