Repository navigation
Implement window_get_x, window_get_y, window_set_position for desktop - #620
Merged
Merged
Conversation
Collaborator
Author
|
This won't work on GLFW2, SDL 1.2 or the web backend |
cobaltgit
marked this pull request as ready for review
October 4, 2026 14:05
Collaborator
|
make them static functions + function pointers in the runner struct, since these functions should be optional. |
Collaborator
Author
|
That's what it should be doing, the builtins check if the runner and function pointer isn't a nullptr before proceeding, otherwise the logic is skipped and it just returns whatever |
Un1q32
reviewed
Oct 7, 2026
Collaborator
Author
|
Ok this should do it |
Un1q32
reviewed
Oct 8, 2026
Collaborator
Author
|
Ok done that |
Collaborator
|
Can you make a test game that runs in 640x480 and moves exactly 640 pixels horizontally and 480 vertically so I can test that hidpi is working correctly. |
Collaborator
Author
|
Hold up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the screen shake at the very end of Undertale's genocide route work, will need testing to confirm