Redesign site: new layout, components, styles, screenshots, and screenshot script - #1
Redesign site: new layout, components, styles, screenshots, and screenshot script#1BryanPan342 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c2ed4263a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "lint:fix": "yarn run eslint --fix && yarn run stylelint --fix", | ||
| "no-lock": "scripts/noPackageLock.sh" | ||
| "no-lock": "scripts/noPackageLock.sh", | ||
| "screenshot": "node scripts/screenshot.js" |
There was a problem hiding this comment.
Declare Playwright for the new screenshot script
In a clean checkout, yarn run screenshot invokes this new script, but scripts/screenshot.js calls require('playwright') and playwright is not listed in dependencies or devDependencies. That means the visual-regression aid exits immediately unless a developer has manually installed an undeclared package, so the new package script is not reproducible from the committed lockfile.
Useful? React with 👍 / 👎.
Motivation
alttext, typed handlers, and richerProjectprops.Description
pages/index.tsxandpages/about.tsxwith new copy and structure, updatedcomponents/Footer.tsx,components/Navbar.tsx, andcomponents/Project.tsxto include semantic markup, accessibility attributes, alt text, typed event handler (onSubmit), and new props (ctaLabel,eyebrow,tags).styles/(Home.module.scss,About.module.scss,Footer.module.scss,Project.module.scss,Navbar.module.scss,globals.scss, and_variables.module.scss) to implement the new layout, design tokens, responsive rules, and color system.screenshots/, a headless capture scriptscripts/screenshot.js, and apackage.jsonscriptscreenshotto run it;.gitignoreupdated to ignore thescreenshots/folder.package.jsonscripts and improved button/link markup and styles across the site.Testing
yarn buildto validate TypeScript and Next.js compilation and the changes to page/component code.yarn run lintto catch obvious style/type issues; both build and lint checks completed successfully.Codex Task