feat: nav oracle contracts and guards - #69
Merged
Merged
Conversation
The suite asserted a monotonic-date guard attest never implemented, so the workspace tests were red. Assert the cooldown and deviation guards it does enforce, and pin the contract-stamped timestamp so changing it is deliberate.
luchobonatti
approved these changes
Sep 7, 2026
Member
There was a problem hiding this comment.
Approved. Clean port, CI green.
One bug: is_stale() never checks the ripcord. A fresh record with the ripcord raised gives state() == Paused but is_stale() == false, and the name reads like a health check. Fold the ripcord in, or rename it is_expired. Worth fixing before #65 consumes this.
luchobonatti
approved these changes
Sep 7, 2026
| panic_with_error!(e, OracleError::CooldownActive); | ||
| } | ||
| // Per-share symmetric deviation cap against the previous strike. | ||
| let diff = (report.nav_per_share - prev.nav_per_share).abs(); |
Member
There was a problem hiding this comment.
The cap uses abs(diff), so it also caps losses. A real 15% drop with a 2% cap takes eight attestations to land, and redemptions pay the inflated price the whole way. Cap the upside only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #64