docs: fix typos in README, CLI help, and public identifiers#24
Conversation
User-facing strings: - README: "Contritubions" -> "Contributions", "Belobog is inspired" -> "Movy is inspired" (the surrounding list is the set of projects Movy was inspired by, including Belobog itself), and "inreases" inside the counter test snippet - test-data/counter/tests/movy.move: matching "inreases" -> "increases" - movy sui fuzz --help: "Ouput directory" -> "Output directory" - movy sui fuzz error message: "MOVY_FORCE_REMOVAl" -> "MOVY_FORCE_REMOVAL" (the actual env var, defined on the same arg, was already spelt correctly) - movy-replay: "Commiting movy_init effects..." -> "Committing ..." Public identifiers (mechanical rename, rustc-verified): - FunctionData.return_paramters -> return_parameters (17 call sites across movy-types, movy-analysis, movy-fuzz) - movy/src/analysis::AnlaysisArgs -> AnalysisArgs (4 sites in movy/src/main.rs and movy/src/analysis/mod.rs) cargo check --workspace is clean; cargo build -p movy --release builds; `movy sui fuzz --help` and the existing-output-dir error path print the corrected strings.
|
Hi! Sorry for late. Would you mind checking if https://github.com/BitsLabSec/movy/tree/v1.65.2-pending covers your PR and #23 ? |
|
Thanks for checking. I took another look at v1.65.2-pending. If the goal is to cover the behavioral issue from #23 / #21, I don’t think it is fully covered yet. In the current branch, crates/movy-fuzz/src/mutators/sequence/append.rs still has the same panic path for conflicting type arguments: panic!("Conflicting type arguments for index {}", i); and the adjacent unwrap/panic paths that #23 relaxed also still seem to be present. Maybe there is another change in v1.65.2-pending that makes this path unreachable, but I could not confirm that from the code. For #24, most of it is typo/public identifier cleanup, so I understand if that is not the main concern for this branch. I did notice those typo fixes are not included yet, but they can be handled separately if you prefer. Since these PRs don’t seem to be aligned with the current development focus, I’ll close them for now. If they become useful later, I’m happy to reopen/rebase/split them as needed. |
Pure typo cleanup. No behavioral changes;
cargo check --workspaceandcargo build -p movy --releaseboth pass.User-facing strings
Readme.mdContributions headingContritubionsContributionsReadme.mdCredits sentenceBelobog is inspired by several pioneering projects:Movy is inspired by several pioneering projects:(the list below includes Belobog itself as an inspiration for Movy)Readme.md+test-data/counter/tests/movy.moveIncrement does not correctly inreases internal value.... correctly increases ...movy sui fuzz --helpOuput directory to save all contentsOutput directory to save all contentsmovy sui fuzzerror msg when output dir existspass -f or env MOVY_FORCE_REMOVAl to always remove it... MOVY_FORCE_REMOVAL ...(the env var itself, declared on the same arg, was already spelled correctly)movy-replaylog lineCommiting movy_init effects...Committing movy_init effects...Public identifier renames
Mechanical, rustc-verified:
FunctionData.return_paramters->return_parameters(definition incrates/movy-types/src/abi.rs, 17 call sites acrossmovy-types,movy-analysis,movy-fuzz)movy::analysis::AnlaysisArgs->AnalysisArgs(crates/movy/src/main.rsandcrates/movy/src/analysis/mod.rs, 4 sites)These are the only two misspelled public identifiers I found in the master tree. Both appear in read-a-lot files (
abi.rsis the function-ABI definition;main.rsis the CLI entry).Scope intentionally kept narrow
crates/movy-sui-stds/.../tests_disbaled/since those only exist onv1.65.2-pending(V1.65.2 pending #20). Happy to follow up once V1.65.2 pending #20 lands.Test plan
cargo check --workspacecargo build -p movy --releasemovy sui fuzz --helpprints "Output directory"