build(wasm-utxo): add support for sBTC address types#272
Merged
OttoAllmendinger merged 4 commits intomasterfrom Apr 30, 2026
Merged
build(wasm-utxo): add support for sBTC address types#272OttoAllmendinger merged 4 commits intomasterfrom
OttoAllmendinger merged 4 commits intomasterfrom
Conversation
davidkaplanbitgo
previously approved these changes
Apr 30, 2026
Update miniscript dependency from 13.0.0-bitgo.2 to 13.0.0-bitgo.3 to include latest fixes. Issue: BTC-3357 Co-authored-by: llm-git <llm-git@ttll.de>
Add ExtParamsConfig struct to enable fine-grained control over miniscript analysis checks when parsing descriptors. This allows callers to selectively enable non-standard behaviors like drop operations, timelock mixing, or malleability. The configuration uses camelCase field names for JavaScript compatibility and defaults all flags to false for sane behavior. Issue: BTC-3357 Co-authored-by: llm-git <llm-git@ttll.de>
Add complete test suite for sBTC protocol's two-leaf taproot tree with deposit (payload_drop) and reclaim (r:older with multi_a) leaves. Verify structure parsing, P2TR output generation, and address derivation. Tests demonstrate proper use of fromStringExt with `drop: true` to enable r:older() in taproot context. Issue: BTC-3357 Co-authored-by: llm-git <llm-git@ttll.de>
…mode Update rust-miniscript dependency from bitgo.3 to bitgo.5. Change all descriptor parsing to use `ExtParams::sane().drop()` by default, allowing r: wrappers while maintaining other safety checks. The `fromStringExt` method now always enables drop mode, with other flags remaining opt-in for taproot leaf validation. Issue: BTC-3357 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-3357.bump-rust-miniscript-for-sbtc
branch
from
6ace6b2 to
5457b17
Compare
davidkaplanbitgo
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive test suite for sBTC protocol's two-leaf taproot
tree with deposit (payload_drop) and reclaim (r:older with multi_a)
leaves. Tests verify structure parsing, P2TR output generation, and
address derivation with proper use of drop mode.
Issue: BTC-3357