Open
Conversation
Member
|
Hi @Young-Sook, thank you for contributing and testing the changes for windows users. This has been on our backlog for quite a while, so i appreciate the help. I'm working on #74 that brings in the newer changes to the rds2cpp library. this should mostly take care of (1). I'll finish this over the weekend and take a deeper look at the PR. after a quick look, It would be nice to
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I used an AI model to make it installable on Windows. It's working pretty well on my side.
Below is the summary of the fixes:
lib/src/rdswrapper.cpp — Updated for new rds2cpp API The upstream rds2cpp library had breaking API changes: Attributes: Changed from a struct with .names/.values vectors to std::vector where each Attribute has a SymbolIndex name + unique_ptr value. Attribute names now require a lookup into a global symbols table. StringVector::data: Changed from vector to vector where String has an optional value (supports missing/NA strings). RdaFile: contents (a PairList-like struct with .tag_names, .has_tag, .data) was replaced by objects (a vector with .name as SymbolIndex and .value). The RdsReader class now carries a const std::vectorrds2cpp::Symbol* pointer to resolve symbol names. Added #include .
lib/CMakeLists.txt — Added zlib for Windows The byteme library conditionally includes gzip support only when zlib.h is available (#if __has_include("zlib.h")). On Windows, zlib isn't typically installed. Added CMake logic to auto-fetch and build zlib from source via FetchContent when the system zlib isn't found.
setup.py — Fixed Windows file copy The old code copied _core.dll → _core.pyd, but the actual CMake output is named lib_rds_parser. pybind11 appends ABI tags (e.g. lib_rds_parser.cp312-win_amd64.pyd), so a glob pattern is now used to find the built file.
setup.cfg — Added Windows platform Changed platforms = Mac, Linux to platforms = Mac, Linux, Windows.
Thanks,
Youngsook