Skip to content

Fix KDE dock icon; add macOS build stubs#4

Merged
prassamin merged 7 commits into
Better-Linux:mainfrom
Joy-Majumder:fix/kde-icon
May 21, 2026
Merged

Fix KDE dock icon; add macOS build stubs#4
prassamin merged 7 commits into
Better-Linux:mainfrom
Joy-Majumder:fix/kde-icon

Conversation

@Joy-Majumder

Copy link
Copy Markdown
Contributor

Overview

Fixes the KDE panel icon issue by aligning the desktop window class with the app window class.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Key Changes

  1. cleanmylinux.desktop: set StartupWMClass=CleanMyLinux.
  2. mod.rs: add non-Linux stubs behind cfg guards for smooth macOS development builds.

Verification Actions

  • Checked backend builds cleanly

Related Issues

Closes #1

Copilot AI review requested due to automatic review settings May 19, 2026 17:52
@vercel

vercel Bot commented May 19, 2026

Copy link
Copy Markdown

@Joy-Majumder is attempting to deploy a commit to the PRAS Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a KDE dock/panel icon mismatch by aligning the .desktop StartupWMClass with the app’s window class, and introduces non-Linux Rust stubs so the Tauri backend can compile for macOS development.

Changes:

  • Set StartupWMClass=CleanMyLinux in the desktop entry to match the Tauri productName.
  • Gate Linux-only system_info modules behind cfg(target_os = "linux").
  • Add non-Linux #[tauri::command] stubs returning empty/default results for macOS dev builds.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src-tauri/src/system_info/mod.rs Adds Linux-only module gating and non-Linux command stubs to keep backend compiling off Linux.
config/cleanmylinux.desktop Updates StartupWMClass to align KDE icon/window-class matching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src-tauri/src/system_info/mod.rs Outdated
@prassamin prassamin added the bug Something isn't working label May 20, 2026
@prassamin
prassamin merged commit b034fd4 into Better-Linux:main May 21, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] App Icon Missing

3 participants