Fix KDE dock icon; add macOS build stubs#4
Merged
Conversation
|
@Joy-Majumder is attempting to deploy a commit to the PRAS Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a KDE dock/panel icon mismatch by aligning the .desktop StartupWMClass with the app’s window class, and introduces non-Linux Rust stubs so the Tauri backend can compile for macOS development.
Changes:
- Set
StartupWMClass=CleanMyLinuxin the desktop entry to match the TauriproductName. - Gate Linux-only
system_infomodules behindcfg(target_os = "linux"). - Add non-Linux
#[tauri::command]stubs returning empty/default results for macOS dev builds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src-tauri/src/system_info/mod.rs |
Adds Linux-only module gating and non-Linux command stubs to keep backend compiling off Linux. |
config/cleanmylinux.desktop |
Updates StartupWMClass to align KDE icon/window-class matching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the KDE panel icon issue by aligning the desktop window class with the app window class.
Type of Change
Key Changes
StartupWMClass=CleanMyLinux.cfgguards for smooth macOS development builds.Verification Actions
Related Issues
Closes #1