Repository navigation
Build each edge as its own path when rendering square modules - #247
Open
mattiasgeniar wants to merge 2 commits into
Open
mattiasgeniar wants to merge 2 commits into
mattiasgeniar wants to merge 2 commits into
Conversation
mattiasgeniar
marked this pull request as ready for review
November 3, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SquareModuleadds every point of every edge to one bigPathwithmove()andline().Pathis immutable, so each call copies all operations added so far, and the cost grows with the square of the number of points. This builds each edge as its own short path and appends it once, so the big path is copied once per edge instead of once per point. It also flips cells inline inEdgeIterator, instead of through two method calls per cell. The SVG output is byte-identical for 264 inputs, and the test suite has the same result asmain(the two GD tests error on both here, without the extension).Writer::writeString(), 400 px SVGWriter::writeString(), first callMedian of 15 fresh PHP 8.5 processes per side, run interleaved, opcache on. "First call" is the first run in a new process.