fix(deps): remove legacy peer deps without downgrading ESLint - #2416
Open
Tatsat (Tats) Mishra 🐉 (Tatsinnit) wants to merge 2 commits into
Open
Tatsat (Tats) Mishra 🐉 (Tatsinnit) wants to merge 2 commits into
Tatsat (Tats) Mishra 🐉 (Tatsinnit) wants to merge 2 commits into
Conversation
CI sets CI=true, which makes typescript-eslint infer single-run mode and compile the type-aware program ahead of time from the files on disk. The first lintText call for a given path was therefore parsed from the real ProgressRing.tsx instead of the snippet under test, so the fragment-key case reported unrelated dom-no-unknown-property errors. Disable automatic single-run inference for the test's ESLint instance so the snippets are linted as written both locally and on CI.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2038.
--legacy-peer-depsoccurrences from the shared install script and fuzzing workflows.eslint-plugin-reactwith@eslint-react/eslint-plugin5.19.0. The published legacy plugin still excludes ESLint 10 from its peer range (ESLint v10 compatibility jsx-eslint/eslint-plugin-react#3977).Coverage Tradeoffs
This is not an exact preset swap. The migration documentation records the differences:
react/no-unescaped-entitieshas no replacement and is no longer enforced.Lockfiles
The root lockfile only reclassifies 59 entries from dev to devOptional after normal peer resolution; versions and integrity hashes are unchanged. The webview lockfile removes the old plugin dependency tree and consolidates the upgraded TypeScript-ESLint dependencies while retaining lockfile version 2.
Validation
Passed locally on macOS with Node 22.22.1 / npm 11.17.0:
npm ci --legacy-peer-deps=false --no-audit --no-fundin both projects.npm_config_legacy_peer_deps=false npm run install:all.npm run lint:all.npm run test:lint --prefix webview-ui: 5 passing.npm test: 289 passing in the VS Code test host.npm run test:fuzz: 28 passing.npm run test:scripts: 53 passing.npm run package: production webpack and VSIX packaging passed.git diff --checkpassed.The webview audit reports zero vulnerabilities. The root retains four findings in unchanged dependencies (two moderate, two high), outside this migration. Cross-platform CI is pending.