fix: AcceleratorType is nil for MI300X sizes - #37
Open
Jose Blanquicet (blanquicet) wants to merge 1 commit into
Open
fix: AcceleratorType is nil for MI300X sizes#37Jose Blanquicet (blanquicet) wants to merge 1 commit into
Jose Blanquicet (blanquicet) wants to merge 1 commit into
Conversation
The accelerator group only allowed letters after the digits when the name also had the "xl_" prefix, so "MI300X" matched neither option and ND96isr_MI300X_v5 and ND96is_MI300X_v5 ended up with a nil AcceleratorType. Made the "xl_" part optional inside the group instead of keeping two separate options. Both MI300X sizes now get AcceleratorType set, and the 1385 sizes in testdata still parse the same way. Added both MI300X sizes to testCases, plus A100, H100, H200 and A10 sizes, which had no cases there before. H100 and H200 share the same Series (NDisr_v5), so AcceleratorType is what tells them apart. Same change in v1 and v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accelerator group has two options:
The first one allows letters after the digits (the trailing
[A-Z]*), but only if the name starts withxl_. The second one has noxl_, but does not allow letters after the digits either.MI300Xneeds the trailing letters and has noxl_prefix, so it matched neither, andND96isr_MI300X_v5andND96is_MI300X_v5ended up with a nilAcceleratorType.This makes the
xl_part optional inside the group instead of keeping two separate options:Both MI300X sizes now get
AcceleratorTypeset. I checked the 1385 sizes intestdata.SKUData: all of them still parse, and these two are the only ones that changed.Added both MI300X sizes to
testCases, plus A100, H100, H200 and A10 sizes, which had no cases there before. H100 and H200 share the sameSeries(NDisr_v5), soAcceleratorTypeis what tells them apart.Same change in v1 and v2.