Add support for new Additive Capabilities - #32
Merged
Matthew Christopher (matthchr) merged 1 commit intoApr 1, 2026
Conversation
Matthew Christopher (matthchr)
commented
Apr 1, 2026
Matthew Christopher (matthchr)
commented
Member
- Regenerate testdata
- Add tests
- Fix bug in testdata generation tool that caused v2 and v1 to be different. Moved both to scan all regions (not every VM size is available in eastus, better to scan everything it gives a more robust test)
Alex Leites (tallaxes)
approved these changes
Apr 1, 2026
Matthew Christopher (matthchr)
force-pushed
the
matthchr/fix-parsing
branch
from
April 1, 2026 20:36
e9cb487 to
f47f78c
Compare
* Regenerate testdata * Add tests * Fix bug in testdata generation tool that caused v2 and v1 to be different. Moved both to scan all regions (not every VM size is available in eastus, better to scan everything it gives a more robust test)
Matthew Christopher (matthchr)
force-pushed
the
matthchr/fix-parsing
branch
from
April 1, 2026 20:38
f47f78c to
c50cd13
Compare
Member
|
do we still want to incorporate #25 to make the format compatible w/ compute.SKU, or should I close that PR? |
Matthew Christopher (matthchr)
changed the title
Member
Author
I don't have the full context on the need/goal there -- maybe a question for Alex Leites (@tallaxes) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.