[connectedvmware] Fix cross-subscription VM onboarding

[aaronngo-microsoft]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedvmware vm create-from-machines

Summary

Fix create-from-machines when the Hybrid Compute machine and vCenter inventory are in different subscriptions.

• Use the global --subscription context as the machine subscription.
• Include both the machine and vCenter subscriptions in the Azure Resource Graph query.
• Restrict the machine side of the query to the selected machine subscription.
• Add subscription ID and subscription name help examples.
• Add deterministic unit coverage and a live cross-subscription scenario.
• Bump connectedvmware to version 1.2.2 and update HISTORY.rst.

Testing

• python -m unittest azext_connectedvmware.tests.latest.test_custom azext_connectedvmware.vmware_utils_test — 14 tests passed.
• Targeted Flake8 checks passed for the changed Python files.
• The live cross-subscription scenario was not run locally because it requires dedicated machine and vCenter resources configured through AZURE_CONNECTEDVMWARE_TEST_* environment variables.

General Guidelines

• Have you run azdev style connectedvmware locally? (azdev is not configured in this environment; targeted Flake8 checks passed.)
• Have you run python scripts/ci/test_index.py -q locally? (src/index.json is unchanged.)
• My extension version conforms to the Extension version schema.

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines. Not applicable; this is an existing extension.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once this pull request is merged into main, a new pull request will update src/index.json automatically.
This pull request updates setup.py and HISTORY.rst and does not modify src/index.json.

[azure-client-tools-bot-prd]

Hi aaronngo-microsoft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[microsoft-github-policy-service]

Thank you for your contribution aaronngo-microsoft! We will review the pull request and get back to you soon.

[Yong Zhang (yonzhan)]

connectedvmware

[Copilot]

Copilot review overview

🟢 Approval recommended

The changes are focused, correctly scoped, and covered by unit and live-test paths.

Review effort: Lite
Findings: None

What changed in this PR

Fixes create-from-machines for machines and vCenters in different subscriptions.

Changes:

• Scopes Resource Graph queries to both subscriptions while filtering machines to the active subscription.
• Adds unit and live cross-subscription coverage.
• Updates help examples, changelog, and extension version.

File	Description
src/​connectedvmware/​setup.py	Bumps version to 1.2.2
src/​connectedvmware/​HISTORY.rst	Documents the fix
src/​connectedvmware/​azext_connectedvmware/​custom.py	Implements cross-subscription query handling
src/​connectedvmware/​azext_connectedvmware/​_help.py	Adds subscription examples
src/​connectedvmware/​azext_connectedvmware/​tests/​latest/​test_custom.py	Adds deterministic unit coverage
src/​connectedvmware/​azext_connectedvmware/​tests/​latest/​test_connectedvmware_scenario.py	Adds live scenario coverage

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Adnan Aslam (adnan529)]

We need to test that the subscription provided in the input parameter to the CLI command is considered in the query here

[vngo4590]

tested in integration test

[ugunarathna-ms]

If I'm reading the logic correctly, we include the subscriptions

1. subscription user got in az cli
2. subscription of the vCenter id

but what about the subscription id provided as an CLI arg https://learn.microsoft.com/en-us/azure/azure-arc/vmware-vsphere/enable-virtual-hardware#link-arc-enabled-server-machines-to-vcenter-using-azure-cli
e.g. contoso-sub

az connectedvmware vm create-from-machines --subscription contoso-sub --vcenter-id /subscriptions/aaaa0a0a-bb1b-cc2c-dd3d-eeeeee4e4e4e/resourceGroups/allhands-demo/providers/microsoft.connectedvmwarevsphere/VCenters/ContosovCentervcenters/contoso-vcenter

[vngo4590]

apparently the subscription set for the list is az cli if no --subscription flag is provided. if --subscription is provided then we will use that subscription

[vngo4590]

see the test: https://github.com/Azure/azure-cli-extensions/pull/10373/changes#diff-3fd3e67e2887386d763f974a595db56a16d13182eac3907c0db1f657aea977cfR85

first i login into hybrid compute sub, then i supplied the vcenter sub as well as the the subscription where i created my VM, then the result in the recording will be the subscriptions of the vm and the vcenter

[Ethan Yang (necusjz)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 2 pipeline(s).