Skip to content

{AKS} Stabilize remaining aks-preview live tests - #10308

Merged
Julie Zhu (yanzhudd) merged 3 commits into
Azure:mainfrom
FumingZhang:fix/aks-preview-live-test-rca-20260904
Sep 8, 2026
Merged

{AKS} Stabilize remaining aks-preview live tests#10308
Julie Zhu (yanzhudd) merged 3 commits into
Azure:mainfrom
FumingZhang:fix/aks-preview-live-test-rca-20260904

Conversation

@FumingZhang

@FumingZhang FumingZhang commented Sep 7, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes
️✔️ None

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks * (aks-preview live tests only)

What / Why

Fixes CLI-side test and scenario issues identified in the post-merge AKS runner logs without changing extension product code or AKS RP:

  • Enable the OIDC issuer and workload identity required by the ALB update scenario.
  • Apply precise feature and resolved-location skips instead of broadly disabling scenarios, including case-insensitive feature-name matching for free-form service errors.
  • Correct virtual-node, upgrades, and full-caching assertions for current service responses.
  • Sequence network-isolated migration operations in the required order.
  • Keep the confidential-compute scenario in a capacity-verified region.
  • Wait for monitoring, KMS rotation, and extension operations to become service-visible before dependent assertions.
  • Split the approximately one-hour HTTP proxy scenario into independent create, update, and disable/re-enable tests, and remove its obsolete monolithic recording.

RP-only issues remain intentionally visible and are not masked by this PR.

Validation

  • pytest src/aks-preview/azext_aks_preview/tests/latest/test_custom_preparers.py -q - 7 passed.
  • pytest --collect-only src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py -q - 388 tests collected.
  • Direct mixed-case feature-error check - precise skip verified.
  • python -m py_compile for all changed Python files - passed.
  • git diff --check upstream/main...HEAD - passed.

Scope / Index / History

  • Every changed path is under src/aks-preview/azext_aks_preview/tests/latest.
  • No extension product code, version, HISTORY.rst, or src/index.json change is needed for this test-only PR.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required) - azdev is unavailable locally; the PR's style workflow provides this check.
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required) - N/A, src/index.json is unchanged.
  • My extension version conforms to the Extension version schema (version unchanged).

For new extensions:

  • N/A - not a new extension.

@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

@FumingZhang
FumingZhang force-pushed the fix/aks-preview-live-test-rca-20260904 branch from 46cdbc1 to af3bb08 Compare September 7, 2026 05:23
@FumingZhang FumingZhang changed the title {AKS} Fix live/runner test failures and scope AKS backup vault discovery {AKS} Stabilize remaining aks-preview live tests Sep 7, 2026
@FumingZhang
FumingZhang marked this pull request as ready for review September 7, 2026 05:26
Copilot AI lite review requested due to automatic review settings September 7, 2026 05:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new _cmd_or_skip_if_feature_unavailable skip detection is case-sensitive and can fail to trigger in practice, causing avoidable live-test failures.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Stabilizes aks-preview live tests by making them more resilient to service-side gating/propagation behavior and region constraints, without changing extension product code.

Changes:

  • Add a targeted helper (skip_test_if_location_unsupported) and unit tests to precisely skip region-gated scenarios when forced RG locations are unsupported.
  • Improve live-test robustness by adding targeted waits and adjusting assertions to match current/consistent RP response shapes.
  • Refactor several scenarios (notably the HTTP proxy scenario) to reduce flakiness/timeouts and apply more precise skip behavior for subscription-gated preview features.
File summaries
File Description
src/aks-preview/azext_aks_preview/tests/latest/test_custom_preparers.py Adds unit coverage for the new precise location-skip helper.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Updates/reshapes multiple live scenarios with precise skips, waits, and assertion fixes to reduce flakes.
src/aks-preview/azext_aks_preview/tests/latest/custom_preparers.py Introduces skip_test_if_location_unsupported to avoid broad decorators and keep skips scoped.
Review details
  • Files reviewed: 3/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
FumingZhang and others added 3 commits September 7, 2026 06:41
Address the post-merge runner failures with precise feature and location skips, corrected assertions and operation ordering, bounded service-readiness waits, and independent HTTP proxy scenarios. Keep the change test-only so no extension release note or version bump is required.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preview feature names in service errors are free-form and may use different casing. Normalize both values so precise enrollment skips remain reliable without masking unrelated failures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The preparers inject the location into each scenario, but shared proxy setup does not consume it. Prefix the helper parameter so the intentional API shape is explicit without triggering unused-argument checks.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@FumingZhang
FumingZhang force-pushed the fix/aks-preview-live-test-rca-20260904 branch from af3bb08 to b944827 Compare September 7, 2026 06:43
@yanzhudd
Julie Zhu (yanzhudd) merged commit c666c29 into Azure:main Sep 8, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants