Pin GitHub Actions to full-length commit SHAs - #10275
Pin GitHub Actions to full-length commit SHAs#10275Dan Fiedler (danfiedler-msft) wants to merge 1 commit into
Conversation
|
Hi Dan Fiedler (@danfiedler-msft), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s CI/CD supply chain by replacing mutable GitHub Actions version tags with full-length commit SHA pins across workflows and the local composite action, and adds a Dependabot configuration for GitHub Actions updates with a 7-day cooldown.
Changes:
- Pin all third-party GitHub Actions references in
.github/workflows/to full-length commit SHAs (with version comments). - Pin GitHub Actions references in the local composite action
.github/actions/env-setup/action.ymlto full-length commit SHAs. - Add
.github/dependabot.ymlto manage GitHub Actions updates with grouping and a 7-day cooldown.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/VersionCalPRComment.yml | Pins referenced actions (checkout/setup-python/upload/download/file-existence/get-labels) to commit SHAs. |
| .github/workflows/TriggerExtensionRelease.yml | Pins azure/login and azure/cli action references to commit SHAs. |
| .github/workflows/TestTriggerExtensionRelease.yml | Pins azure/login and azure/cli action references to commit SHAs. |
| .github/workflows/GitHookNotice.yml | Pins actions/checkout to a commit SHA. |
| .github/workflows/CreateReleaseTag.yml | Pins actions/checkout and actions/setup-python to commit SHAs. |
| .github/workflows/CCOA.yml | Pins actions/github-script to a commit SHA. |
| .github/workflows/BlockPRMerge.yml | Pins actions/github-script to a commit SHA. |
| .github/workflows/AzdevStyle.yml | Pins actions/checkout to a commit SHA. |
| .github/workflows/AzdevLinter.yml | Pins actions/checkout to a commit SHA. |
| .github/workflows/AddIssueCommentWithLabel.yml | Pins actions/checkout and mshick/add-pr-comment to commit SHAs. |
| .github/workflows/AddIssueComment.yml | Pins hasura/comment-progress to a commit SHA. |
| .github/dependabot.yml | Adds Dependabot config for github-actions with grouping and a 7-day cooldown. |
| .github/actions/env-setup/action.yml | Pins actions/checkout and actions/setup-python to commit SHAs within the composite action. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Pin GitHub Actions |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
🤖 PR Validation — ️✔️ All clear
Summary
This PR pins GitHub Actions to full-length commit SHAs for improved security and reproducibility and adds a 7 day cooldown to Dependabot configuration for GitHub Actions. This work is described in more detail at https://aka.ms/action-pinning.
Why?
Pinning actions to commit SHAs prevents supply-chain attacks where a tag could be moved to point to malicious code. This is a recommended security best practice per the GitHub Actions security hardening guide.
This change mitigates the risk of tag retargeting to malicious code as seen in incidents like the tj-actions/changed-files action compromise or codfish/semantic-release-action compromise and improves the integrity and reproducibility of the CI/CD pipeline.
What changed?
Action pinning: Third-party action references in
.github/workflows/that used mutable tag-based references (e.g.,actions/checkout@v4) have been updated to full-length commit SHAs with a version comment (e.g.,actions/checkout@<sha> # v4) using the pinact tool. References that were already pinned to a SHA, or that used immutable release tags, were left unchanged.Dependabot configuration:
.github/dependabot.ymlhas been updated to ensure agithub-actionspackage-ecosystem section is present with acooldownconfiguration (default-days: 7). If the file did not exist, it was created. If agithub-actionssection already existed, only thecooldownblock was added or itsdefault-daysvalue was increased to 7 if it was lower. The 7-day cooldown provides a window for the community to detect and report compromised releases before they are automatically proposed as updates, reducing exposure to supply-chain attacks via newly published malicious versions.Is this safe to merge?
Yes. The pinned SHAs correspond to the same commits that the existing tags pointed to. No behavioral changes in action execution are introduced. You can verify the pinned SHA value using the GitHub REST API (e.g., the commit hash for
actions/checkout@v7can be found in theshaproperty in the JSON response forGET https://api.github.com/repos/actions/checkout/commits/v7).Additional Information
For more information, please see https://aka.ms/action-pinning