[CosmosDB] Fix #8080: az cosmosdb: Fix malformed redistribute-partition-throughput help examples - #10209
Conversation
|
Hi Hashim Khan (@Hashim1999164), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Removes stray trailing bracket/quote characters from Cosmos DB redistribute-partition-throughput help examples in the cosmosdb-preview extension so the sample commands are valid when copied from CLI help.
Changes:
- Fix SQL container redistribute example by removing the trailing
]'and using a valid--source-partition-infovalue. - Fix MongoDB collection redistribute example by removing the trailing
'characters and using a valid--source-partition-infovalue.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
cosmosdb |
|
Added a HISTORY.rst entry and bumped cosmosdb-preview to 1.7.1 for the redistribute help example fix. |
az cosmosdb: Fix malformed redistribute-partition-throughput help examples
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
please address the feedback in the failed tests and commit a fix |
Live test skipped⏭️ Skipping the live test for this revision because no changed test file was found ( The live-test pipeline runs only the test files a PR changes, so there is nothing to execute for this commit. A skipped live test is not a passing test result. The Agent review separately checks whether the affected command module includes focused regression tests or updated recordings. If a test file is changed in a later commit, the live test will run automatically. |
There was a problem hiding this comment.
CI Review Summary
Upstream CI
Azure.azure-cli-extensions build 341169 — failure
azdev linter on Modified Extensions/azdev style on Modified Extensions: the quoted task-log evidence referencessrc/quantum/azext_quantum/...andsrc/quantum/setup.py— files this PR never touches (it only modifiessrc/cosmosdb-preview/HISTORY.rst,_help.py, andsetup.py). This build output does not correspond to this PR's changes; classified not PR-related.- Next action: re-run the two failed jobs; if the quantum-extension diagnostic persists, escalate to the pipeline owner rather than changing this PR's cosmosdb-preview source.
Test validation
- Live test: skipped — this PR only edits help text and
HISTORY.rst, notests/**/test_*.pyfiles. - Regression coverage: not applicable — no command-module production code changed, only help examples.
Repository policy findings
None.
Classification
All current failures are not PR-related (stale/shared build output for an unrelated quantum extension). No source change is requested; recommend re-running the two failed jobs.
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
@Azure-Client-Tools-Agent,
Upstream CI
Azure.azure-cli-extensions
-
Result: failure
-
Included checks:
Integration Tests, Build Tests Python313/Python314/Python310/Python311/Python312,azdev linter on Modified Extensions,azdev style on Modified Extensions -
Integration Tests (all Python versions) — Not PR-related. All 49 failures are in
src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/test_cosmosdb_sql_adaptiveru_scenario.py,test_cosmosdb_sql_materializedview_scenario.py,test_cosmosdb_table_rbac_assignment_scenario.pyandtest_cosmosdb_table_rbac_scenario.py. This PR only changesHISTORY.rst,_help.py(help text) andsetup.py(version bump) — no test files, no client/command logic. These recorded scenario tests were already failing independently of this PR's diff.- Next action: No source change requested for this failure; recommend re-running or investigating the underlying
cosmosdb-previewscenario test recordings/environment separately from this PR. - Verify: Re-run
Integration Tests, Build Testsafter confirming the pre-existingcosmosdb-previewtest failures are fixed independently.
- Next action: No source change requested for this failure; recommend re-running or investigating the underlying
-
azdev linter / azdev style on Modified Extensions — Not PR-related. Both failures report
src/quantum/azext_quantum/tests/latest/test_quantum_jobs.pyandsrc/quantum/setup.pymodifyingsrc/index.jsonalongside source code — thequantumextension is not touched anywhere in this PR (onlycosmosdb-previewfiles changed). This is a leftover/aggregate lint failure from another change in the build, not from this PR's diff.- Next action: No source change requested for this failure; recommend re-running the linter/style checks or verifying isolation between concurrent extension builds.
- Verify: Re-run
azdev linter on Modified Extensionsandazdev style on Modified Extensionsand confirm the quantum-related diagnostic no longer appears for this PR.
Test validation
- Live test: Skipped: no runnable changed test files were found (PR changes no
tests/**/test_*.pyfiles). - Regression coverage: Not applicable — the change is help-text and version metadata only.
Review-skill findings
No deterministic skill findings. Semantic checks confirm this PR's diff is scoped correctly to cosmosdb-preview help text/version/HISTORY, matching the stated title and issue #8080.
Summary: All 8 failing checks reference cosmosdb-preview scenario tests and quantum extension files that are unrelated to this PR's actual diff (_help.py/HISTORY.rst/setup.py only). No source change is requested; recommend rerunning/escalating these unrelated failures.
|
Hashim Khan (@Hashim1999164) please fix the issues found by the failing tests |
|
Hi Cooper, thanks for taking a look. The GitHub azdev linter and azdev style checks on this PR are passing. The Azure Pipelines failures are not coming from the help example edits. This PR only changes three files in the cosmosdb preview extension: the help examples, HISTORY.rst, and the version in setup.py. No test files and no command logic were changed. The integration job reports 49 failed scenario tests (16 passed, 11 skipped). Those failures are playback cassette errors in the existing cosmosdb preview scenario tests (PITR, in account restore, softdelete, adaptive RU, table RBAC, and similar). They do not exercise the redistribute help examples. The Azure Pipelines azdev linter and style jobs also failed before running those tools, because the changed file list included quantum extension files and src/index.json together. This PR does not touch quantum or index.json. Happy to rerun pipelines if that helps. I do not think a source change on this PR will clear those failures. |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
🤖 PR Validation — ❌ Action needed
❌Azure CLI Extensions Breaking Change Test
Summary
Fixes #8080
Removes the stray
]'/'characters from the Cosmos DB redistribute-partition-throughput help examples for SQL containers and MongoDB collections so the sample commands are valid.Test plan
]''