Add trusted-host-subscription commands - #10174
Open
kellylu2sym wants to merge 2 commits into
Open
Conversation
Add `az computelimit trusted-host-subscription` command group with add, list, remove and show commands (API version 2026-07-31), generated via aaz-dev and aligned with the existing guest-subscription/shared-limit naming convention (add/list/remove/show, no update). Includes record-only scenario tests and negative/validation tests, and bumps the extension version to 1.1.0.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new az computelimit trusted-host-subscription command group to the computelimit extension (AAZ-generated, API version 2026-07-31), along with scenario/validation tests and a version bump to ship the feature.
Changes:
- Introduces
computelimit trusted-host-subscriptioncommands:add,list,remove,show. - Adds record-only scenario tests plus negative/validation tests and corresponding test recordings.
- Bumps extension version to
1.1.0and updates release history.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/computelimit/setup.py | Bumps extension version to 1.1.0. |
| src/computelimit/HISTORY.rst | Adds 1.1.0 changelog entry for the new command group. |
| src/computelimit/azext_computelimit/tests/latest/test_computelimit.py | Adds trusted-host-subscription scenario + validation tests. |
| src/computelimit/azext_computelimit/tests/latest/recordings/test_computelimit_trusted_host_subscription_add.yaml | Recording for trusted-host-subscription add. |
| src/computelimit/azext_computelimit/tests/latest/recordings/test_computelimit_trusted_host_subscription_list.yaml | Recording for trusted-host-subscription list. |
| src/computelimit/azext_computelimit/tests/latest/recordings/test_computelimit_trusted_host_subscription_remove.yaml | Recording for trusted-host-subscription remove. |
| src/computelimit/azext_computelimit/tests/latest/recordings/test_computelimit_trusted_host_subscription_show.yaml | Recording for trusted-host-subscription show. |
| src/computelimit/azext_computelimit/tests/latest/recordings/test_computelimit_trusted_host_subscription_crud.yaml | Recording for trusted-host-subscription CRUD flow. |
| src/computelimit/azext_computelimit/aaz/latest/computelimit/trusted_host_subscription/__cmd_group.py | Registers the new trusted-host-subscription command group. |
| src/computelimit/azext_computelimit/aaz/latest/computelimit/trusted_host_subscription/init.py | Exposes the trusted_host_subscription command modules. |
| src/computelimit/azext_computelimit/aaz/latest/computelimit/trusted_host_subscription/_add.py | Implements PUT/create for trusted host subscription trust. |
| src/computelimit/azext_computelimit/aaz/latest/computelimit/trusted_host_subscription/_list.py | Implements list-by-location (paging-enabled). |
| src/computelimit/azext_computelimit/aaz/latest/computelimit/trusted_host_subscription/_remove.py | Implements delete with confirmation support. |
| src/computelimit/azext_computelimit/aaz/latest/computelimit/trusted_host_subscription/_show.py | Implements get/show by location + host subscription id. |
Comment on lines
+47
to
+59
| _args_schema.host_subscription_id = AAZStrArg( | ||
| options=["-n", "--name", "--host-subscription-id"], | ||
| help="The name of the TrustedHostSubscription", | ||
| required=True, | ||
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[0-9a-fA-F]{8}(-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}$", | ||
| ), | ||
| ) | ||
| _args_schema.location = AAZResourceLocationArg( | ||
| required=True, | ||
| id_part="name", | ||
| ) |
Comment on lines
+44
to
+56
| _args_schema.host_subscription_id = AAZStrArg( | ||
| options=["-n", "--name", "--host-subscription-id"], | ||
| help="The name of the TrustedHostSubscription", | ||
| required=True, | ||
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[0-9a-fA-F]{8}(-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}$", | ||
| ), | ||
| ) | ||
| _args_schema.location = AAZResourceLocationArg( | ||
| required=True, | ||
| id_part="name", | ||
| ) |
Comment on lines
+45
to
+57
| _args_schema.host_subscription_id = AAZStrArg( | ||
| options=["-n", "--name", "--host-subscription-id"], | ||
| help="The name of the TrustedHostSubscription", | ||
| required=True, | ||
| id_part="child_name_1", | ||
| fmt=AAZStrArgFormat( | ||
| pattern="^[0-9a-fA-F]{8}(-[0-9a-fA-F]{4}){3}-[0-9a-fA-F]{12}$", | ||
| ), | ||
| ) | ||
| _args_schema.location = AAZResourceLocationArg( | ||
| required=True, | ||
| id_part="name", | ||
| ) |
Comment on lines
+45
to
+47
| _args_schema.location = AAZResourceLocationArg( | ||
| required=True, | ||
| ) |
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
Automated sensitive-information remediation ran on this pull request.
If a credential was exposed, rotate or revoke it immediately. Detected values are never copied into this comment. ✅ Keep the redaction · ❌ Dispute the redaction GitHub only supports a fixed reaction set, so 👍 represents ✅ and 👎 represents ❌. The bot-created reactions are only poll choices. Posted by agent-assist (autonomous bug-fix pipeline). |
Live test results —
|
![x-engineering-agent[bot]](https://avatars.githubusercontent.com/in/4205534?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ All checks passed
- Live test (Tester): passed (dispatched
live-test.yml, run completed successfully). - CI checks: 28/28 completed checks passed, 0 failed, 0 pending.
This PR looks good from an automated review perspective. Handing back for maintainer merge decision.
x-engineering-agent
Bot
added
azure-client-tools-agent
and removed
Azure Client Tools Agent Requested
labels
Aditya Pujara (a0x1ab)
added
X Engineering Agent Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
Add
az computelimit trusted-host-subscriptioncommand group with add, list, remove and show commands (API version 2026-07-31), generated via aaz-dev and aligned with the existing guest-subscription/shared-limit naming convention (add/list/remove/show, no update).Includes record-only scenario tests and negative/validation tests, and bumps the extension version to 1.1.0.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.