Fix Packager base dir for Azure Arc - #370
Closed
kjohn-msft wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how the extension ZIP is created by the packager so the resulting archive has the expected base directory layout when unzipped in Azure Arc (notably with PowerShell Core’s unzip behavior), while keeping Azure behavior unchanged.
Changes:
- Update
shutil.make_archive’sbase_dirfrom..to.so the ZIP contents are rooted correctly from theoutdirectory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 109 109
Lines 20642 20642
=======================================
Hits 19425 19425
Misses 1217 1217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yashnap
approved these changes
Jul 30, 2026
Collaborator
Author
|
Had a different team member push the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses an issue in Arc where unzipping the latest version is not working with PowerShell Core-based unzip.
There is no issue with this in Azure.