Add regression coverage for queue metadata/policy persistence across restarts - #2768
Draft
Akanksha Jain (jainakanksha-msft) with Copilot wants to merge 2 commits into
Draft
Add regression coverage for queue metadata/policy persistence across restarts#2768Akanksha Jain (jainakanksha-msft) with Copilot wants to merge 2 commits into
Akanksha Jain (jainakanksha-msft) with Copilot wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started work on behalf of
Akanksha Jain (jainakanksha-msft)
September 2, 2026 12:42
View session
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add state persistence for queues in Docker images
Add regression coverage for queue metadata/policy persistence across restarts
Sep 2, 2026
Copilot started reviewing on behalf of
Akanksha Jain (jainakanksha-msft)
September 2, 2026 12:48
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new test includes a service-port mismatch and uses an invalid ISO date plus an overly strict equality assertion that can make the regression coverage brittle or misleading.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Lite
Comment on lines
+25
to
+27
| const host = "127.0.0.1"; | ||
| const port = 11002; | ||
| const metadataDbPath = "__queuePersistenceTestsStorage__"; |
Comment on lines
+94
to
+97
| accessPolicy: { | ||
| expiresOn: new Date("2030-11-31T11:22:33.4567890Z"), | ||
| permissions: "raup", | ||
| startsOn: new Date("2017-12-31T11:22:33.4567890Z") |
Comment on lines
+128
to
+130
|
|
||
| const policyResult = await queueClient.getAccessPolicy(); | ||
| assert.deepStrictEqual(policyResult.signedIdentifiers, queueAcl); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users requested the ability to persist queue state (queues, metadata, and stored access policies) so pre-initialized test environments and Docker images could be built without custom startup scripts, mirroring existing blob container persistence.
Investigation
LokiQueueMetadataStorealready persists queues, metadata, and access policies (ACLs) to disk via LokiJS, on par with blob container persistence, enabled by default unless--inMemoryPersistenceis set.Changes
tests/queue/queuePersistence.test.ts: a disk-backed regression test that creates a queue with metadata and an access policy, restarts theQueueServeragainst the same DB paths, and asserts all three survive the restart.No production code changes were required — this PR locks in the existing behavior with explicit regression coverage.