Repository navigation
fix: add missing favicon.ico to workflow-vite - #904
Merged
Merged
Conversation
jordan-a-young
requested review from
LauRoxx and
gregmartDOTin
as code owners
September 21, 2026 21:54
The fallback favicon path in generateIndexHtml pointed to ./public/favicon.ico within the package, but the file was never included. This caused the generated index.html to reference a node_modules path that doesn't resolve correctly in built output. Copied from packages/workflow/public/favicon.ico.
jordan-a-young
force-pushed
the
fix/workflow-vite-favicon
branch
from
September 21, 2026 21:58
ae8cf4e to
2af836d
Compare
….28 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
generateIndexHtmlfunction invite.config.jsincludes a fallback to./public/favicon.icowithin the package when no project-level favicon exists. However, that file was never actually included in the package, so the fallback always resolved to a brokennode_modulespath like:This path doesn't resolve correctly in built output, so apps without their own
favicon.icogot no favicon.Fix
Copy the existing
favicon.icofrompackages/workflow/public/intopackages/workflow-vite/public/. The path logic ingenerateIndexHtmlalready handles this correctly — it just needed the file to be there.Behavior After Fix
project/app/favicon.ico→ unchanged, uses their file