Skip to content

fix(workflow-vite): resolve lint hanging in TypeScript-only projects #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordan-a-young merged 1 commit into from
Jun 29, 2026
Merged

fix(workflow-vite): resolve lint hanging in TypeScript-only projects #877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/workflow-vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Settings from './settings/index.js';
function handleError(command, error) {
Logger.error(`Command "${command}" failed:`);
Logger.error(error?.stack || error?.message || error);
process.exitCode = 1;
process.exit(1);
}

function getStagingOptions() {
Expand Down
7 changes: 5 additions & 2 deletions packages/workflow-vite/scripts/lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default async function lint({ settings }) {

let engine;
try {
engine = new eslint.ESLint({});
engine = new eslint.ESLint({ errorOnUnmatchedPattern: false });
} catch (error) {
Logger.failed(`ESLint configuration error. "${error.message}"`);
throw new Error(`ESLint configuration error. "${error.message}"`);
Expand All @@ -52,7 +52,10 @@ export default async function lint({ settings }) {
const { stdout: rootOut } = await execFileAsync('git', ['rev-parse', '--show-toplevel']);
const gitRoot = rootOut.trim();
const { stdout: filesOut } = await execFileAsync('git', ['ls-files']);
const gitTrackedFiles = filesOut.trim().split('\n').map((file) => path.join(gitRoot, file));
const gitTrackedFiles = filesOut
.trim()
.split('\n')
.map((file) => path.join(gitRoot, file));
filesToLint = gitTrackedFiles.filter((file) => ['.js', '.jsx', '.ts', '.tsx'].includes(path.extname(file)));
} catch {
// If git commands fail, fall back to default patterns
Expand Down
Loading