Skip to content

feat: check AAF logins and link to existing account if needed (AAI-874) - #294

Merged
marius-mather merged 19 commits into
aaf-devfrom
feat/aaf-account-linking
Aug 25, 2026
Merged

marius-mather merged 19 commits into
aaf-devfrom
feat/aaf-account-linking

Conversation

@marius-mather

@marius-mather marius-mather commented Aug 25, 2026 •

Copy link
Copy Markdown
Collaborator

Description

AAI-874: implement /aaf/check-link endpoint to check AAF logins: if the email is associated with an existing Auth0 account (in the database connection), link the accounts.

Logic is outlined in this docuement: https://docs.google.com/document/d/1OtwUFvXt3KuSDzYP2lLUNQPRtcVG0fUGda5xRKlymvc/edit?usp=sharing, particularly the diagram.

Changes

  • Implement /aaf/check-link endpoint
  • other_user_id column for BiocommonsUser table in database: we don't want to rely on this too much (Auth0 is the source of truth), but useful to have recorded
  • Unit tests

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit / integration tests that prove my fix is effective or that my feature works
  • I have run all tests locally and they pass
  • I have updated the documentation (if applicable)
  • For any new secrets, I have updated the shared spreadsheet and the GitHub Secrets.

How to Test Manually (if necessary)

<Describe how reviewers can manually, if necessary, test the changes>

@amandazhuyilan amandazhuyilan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look through and looks pretty good to me - seems like we have implemented everything we designed well!

@marius-mather
marius-mather merged commit 269c562 into aaf-dev Aug 25, 2026
4 checks passed
@marius-mather
marius-mather deleted the feat/aaf-account-linking branch August 25, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants