Increase CMD column width to 15 characters for full thread names#381
Open
re2zero wants to merge 1 commit into
Open
Increase CMD column width to 15 characters for full thread names#381re2zero wants to merge 1 commit into
re2zero wants to merge 1 commit into
Conversation
According to pthread_setname_np(3), thread names can be up to 15 characters (16 bytes including null terminator). The CMD column was previously limited to 14 characters, causing the last character of thread names to be truncated. This change increases the CMD column width from 14 to 15 characters to display full thread names. Fixes Atoptool#321
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to
pthread_setname_np(3), thread names can be up to 15 characters (16 bytes including the null terminator). The CMD column in atop was previously limited to 14 characters, which caused the last character of thread names to be truncated.This change increases the CMD column width from 14 to 15 characters to display full thread names.
Changes
procprt_CMD_a()from 15 to 16 bytesprocprt_CMD_e()from 15 to 16 bytes (and helpbuf from 15 to 17)%-14.14sto%-15.15sprocprt_CMDstruct: column header width andwidthfield from 14 to 15Test Plan
Fixes #321