Skip to content

Say what each action on a stock row will do - #144

Merged
suskozaver merged 1 commit into
ArunNGun:betafrom
suskozaver:every-action-says-what-it-does
Oct 2, 2026
Merged

suskozaver merged 1 commit into
ArunNGun:betafrom
suskozaver:every-action-says-what-it-does

Conversation

@suskozaver

Copy link
Copy Markdown
Collaborator

Asked for on Mark empty and Delete, with the reasonable complaint that a row offers several buttons and explains none of them, and that other people will wonder the same thing.

Given to all seven rather than those two. Two buttons out of seven carrying an explanation reads as a warning about those two rather than as help, and the question behind the request, what does this do to my records, is the same question for the rest.

The wording says what changes and what survives, because that is what was being asked:

  • Mark empty keeps the vial and its doses and stops it counting towards stock
  • Delete takes the vial, its price and whatever is left in it, leaves logged doses holding their amount and their day, and cannot be undone
  • It arrived dates the stock from today rather than from the day it was ordered, which nothing on screen currently says
  • Add diluent leaves the mass alone, so the concentration drops and every dose takes more volume, and the beyond-use date does not move

title rather than anything of our own: it is what the marks and the other hover explanations already use, it needs no state and nothing to dismiss, and it costs a touch screen nothing because it does not appear there.

Eight new keys, written in all four languages.

Worth your decision, not in here

Delete has no confirmation. One click removes the vial, its price and its remaining mass, and there is no undo, which is almost certainly why this was asked about Delete first. The Log already puts deleting a day behind a confirmation, so the pattern and the precedent both exist. It is a behaviour change rather than a tooltip, so it is not in this PR.

Checks

npx tsc --noEmit clean, npx next lint clean, 1736 tests pass.

Asked for on Mark empty and Delete, with the reasonable complaint that
a row offers several buttons and explains none of them, and that other
people will wonder the same thing.

Given to all seven rather than those two. Two buttons out of seven
carrying an explanation reads as a warning about those two rather than
as help, and the question behind the request, what does this do to my
records, is the same question for the rest of them.

The wording says what changes and what survives, because that is what
was actually being asked. Mark empty keeps the vial and its doses and
stops it counting. Delete takes the vial, its price and whatever is
left in it, leaves logged doses holding their amount and their day, and
cannot be undone. It arrived dates the stock from today rather than
from the day it was ordered, which is a detail nothing on screen says.

title rather than anything of our own. It is what the marks and the
other hover explanations already use, it needs no state and nothing to
dismiss, and it costs a touch screen nothing because it does not appear
there.

Eight new keys, written in all four languages.
@vercel

vercel Bot commented Oct 2, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Arun's projects Team on Vercel.

A member of the Team first needs to authorize it.

@suskozaver
suskozaver merged commit 39b5395 into ArunNGun:beta Oct 2, 2026
1 of 2 checks passed
@suskozaver
suskozaver deleted the every-action-says-what-it-does branch October 2, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant