Repository navigation
Say what each action on a stock row will do - #144
Merged
suskozaver merged 1 commit intoOct 2, 2026
Merged
Conversation
Asked for on Mark empty and Delete, with the reasonable complaint that a row offers several buttons and explains none of them, and that other people will wonder the same thing. Given to all seven rather than those two. Two buttons out of seven carrying an explanation reads as a warning about those two rather than as help, and the question behind the request, what does this do to my records, is the same question for the rest of them. The wording says what changes and what survives, because that is what was actually being asked. Mark empty keeps the vial and its doses and stops it counting. Delete takes the vial, its price and whatever is left in it, leaves logged doses holding their amount and their day, and cannot be undone. It arrived dates the stock from today rather than from the day it was ordered, which is a detail nothing on screen says. title rather than anything of our own. It is what the marks and the other hover explanations already use, it needs no state and nothing to dismiss, and it costs a touch screen nothing because it does not appear there. Eight new keys, written in all four languages.
|
Someone is attempting to deploy a commit to the Arun's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked for on Mark empty and Delete, with the reasonable complaint that a row offers several buttons and explains none of them, and that other people will wonder the same thing.
Given to all seven rather than those two. Two buttons out of seven carrying an explanation reads as a warning about those two rather than as help, and the question behind the request, what does this do to my records, is the same question for the rest.
The wording says what changes and what survives, because that is what was being asked:
titlerather than anything of our own: it is what the marks and the other hover explanations already use, it needs no state and nothing to dismiss, and it costs a touch screen nothing because it does not appear there.Eight new keys, written in all four languages.
Worth your decision, not in here
Delete has no confirmation. One click removes the vial, its price and its remaining mass, and there is no undo, which is almost certainly why this was asked about Delete first. The Log already puts deleting a day behind a confirmation, so the pattern and the precedent both exist. It is a behaviour change rather than a tooltip, so it is not in this PR.
Checks
npx tsc --noEmitclean,npx next lintclean, 1736 tests pass.