Replace Pico CSS with the anyblades pico fork - #915
Merged
Conversation
Contributor
|
thanks! btw we removed the solveit class thing in a separate commit |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: '[PR] Replace Pico CSS CDN assets with anyblades CSS fork'
labels: ''
assignees: ''
Related Issue
#883
Proposed Changes
set_pico_cls()can support Solveit as well as Jupyter. For Solveit, it can add thepicoclass to.msg-contentelements inside.card-outHowever, automatically placing every Solveit output under the pico scope changes the appearance of normal outputs that are not intended to be Pico UI.
Default SolveIt:


With picocond:
Not blocking, but I’m not sure whether there is a better way to handle this. @jph00
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply:Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.