add recursive search from jsonld#731
Open
lvoxpq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
No related issue
Proposed Changes:
The date wasn't being extracted for https://www.obsidiansecurity.com/blog/when-is-stdio-mcp-actually-a-vulnerability
The reason was that the json ld saved "datePublished" in a nested object and newspaper4k checked only for the 1st keys:
How did you test it?
pytest -q and manually to extract the date from html.
pytest had 17 failures, but all of them are not related to the functionality (I decided not to install additional libraries)
Here is the list of failed tests:
Notes for the reviewer
Please check if nested solution is needed. If not change to support "blogpost" key and then search for datePublished in this object.